QazCetelic commented on code in PR #7856:
URL: https://github.com/apache/opendal/pull/7856#discussion_r3530830686
##########
core/services/mini_moka/src/backend.rs:
##########
@@ -135,6 +135,7 @@ impl MiniMokaBackend {
write_can_empty: true,
delete: true,
list: true,
+ shared: false,
Review Comment:
Yes, I decided to also set it because all other services also explicitly set
it to false.
https://github.com/apache/opendal/blob/4f1df1216b0ecb8f2a1ba331dc82364ba957c732/core/services/cacache/src/backend.rs#L65
https://github.com/apache/opendal/blob/4f1df1216b0ecb8f2a1ba331dc82364ba957c732/core/services/cloudflare-kv/src/backend.rs#L174
https://github.com/apache/opendal/blob/4f1df1216b0ecb8f2a1ba331dc82364ba957c732/core/services/dashmap/src/backend.rs#L101
https://github.com/apache/opendal/blob/4f1df1216b0ecb8f2a1ba331dc82364ba957c732/core/services/moka/src/backend.rs#L205
https://github.com/apache/opendal/blob/4f1df1216b0ecb8f2a1ba331dc82364ba957c732/core/services/persy/src/backend.rs#L139
https://github.com/apache/opendal/blob/4f1df1216b0ecb8f2a1ba331dc82364ba957c732/core/services/redb/src/backend.rs#L151
https://github.com/apache/opendal/blob/4f1df1216b0ecb8f2a1ba331dc82364ba957c732/core/services/rocksdb/src/backend.rs#L101
https://github.com/apache/opendal/blob/4f1df1216b0ecb8f2a1ba331dc82364ba957c732/core/services/sled/src/backend.rs#L125
https://github.com/apache/opendal/blob/4f1df1216b0ecb8f2a1ba331dc82364ba957c732/core/services/sqlite/src/backend.rs#L191
I can add a commit to remove those lines if you'd prefer avoiding setting
implicitly defined capabilities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
