chitralverma commented on code in PR #7883:
URL: https://github.com/apache/opendal/pull/7883#discussion_r3552658632
##########
bindings/python/src/services.rs:
##########
@@ -273,3 +266,6974 @@ impl_enum_to_str!(
YandexDisk => "yandex-disk",
}
);
+
+pub trait ConfigBuilder: Send + Sync {
Review Comment:
It is an object-safety shim. `from_config` takes the base
`ServiceConfig(Box<dyn ConfigBuilder>)`, but core `Configurator` cannot be
`dyn` (it is `Serialize + DeserializeOwned + Sized`). `ConfigBuilder` is the
minimal trait that lets the base erase the concrete config type.
Same role as Java's `ServiceConfig` interface. Open to reshaping it — any
preferred design for the type-erased base?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
