QuakeWang commented on PR #7888: URL: https://github.com/apache/opendal/pull/7888#issuecomment-4926580315
> I believe the real problem is reqsign didn't keep the raw query as is, we should fix at reqsign side so we don't need to have this query restore logic. > > And before we are going too crazy: version id returned by services is always picked and a randomly generated string. So I'm ok to really fix it but I don't want to merge PR like this one. > > Both `percent_encode_path` and `percent_decode_path` here are all no-op (at least for 99% cases, I didn't see a real report). @Xuanwo Thanks for the review. I agree that the root fix should happen in reqsign-core instead of adding service-local query restoration logic in OpenDAL. I've opened an issue to track it: https://github.com/apache/opendal-reqsign/issues/778 I'll pause this PR and will fix the reqsign side firstly, then revisit this change with the workaround removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
