svn commit: r1135790 - in /openejb/trunk/sandbox/tools/src/main/java/org/apache/openejb/tools/twitter: OpenEJBMessageFilterUtil.java RetweetAppConstants.java

[rmannibucau]

Author: rmannibucau
Date: Tue Jun 14 20:54:07 2011
New Revision: 1135790

URL: http://svn.apache.org/viewvc?rev=1135790&view=rev
Log:
fixing locale used by tweeter

Modified:
    
openejb/trunk/sandbox/tools/src/main/java/org/apache/openejb/tools/twitter/OpenEJBMessageFilterUtil.java
    
openejb/trunk/sandbox/tools/src/main/java/org/apache/openejb/tools/twitter/RetweetAppConstants.java

Modified: 
openejb/trunk/sandbox/tools/src/main/java/org/apache/openejb/tools/twitter/OpenEJBMessageFilterUtil.java
URL: 
http://svn.apache.org/viewvc/openejb/trunk/sandbox/tools/src/main/java/org/apache/openejb/tools/twitter/OpenEJBMessageFilterUtil.java?rev=1135790&r1=1135789&r2=1135790&view=diff
==============================================================================
--- 
openejb/trunk/sandbox/tools/src/main/java/org/apache/openejb/tools/twitter/OpenEJBMessageFilterUtil.java
 (original)
+++ 
openejb/trunk/sandbox/tools/src/main/java/org/apache/openejb/tools/twitter/OpenEJBMessageFilterUtil.java
 Tue Jun 14 20:54:07 2011
@@ -27,9 +27,9 @@ import java.util.Map;
 
 import org.apache.log4j.Logger;
 
-public class OpenEJBMessageFilterUtil {
+public class OpenEJBMessageFilterUtil implements RetweetAppConstants {
        
-       static SimpleDateFormat dateFormat = new 
SimpleDateFormat(RetweetAppConstants.TWITTER_DATE_FORMAT);
+       static SimpleDateFormat dateFormat = new 
SimpleDateFormat(TWITTER_DATE_FORMAT, TWITTER_LOCALE);
        private static Logger logger = 
Logger.getLogger(OpenEJBMessageFilterUtil.class);
        
        @SuppressWarnings("rawtypes")
@@ -80,15 +80,17 @@ public class OpenEJBMessageFilterUtil {
        String dateAsString =(String) keyValue.get("created_at");
        Calendar calendar = Calendar.getInstance();
        calendar.add(Calendar.HOUR_OF_DAY, -1);
+
+        Date tweetDate;
        try {
-                       Date tweetDate = dateFormat.parse(dateAsString);
-                       logger.debug("Older than an hour?: 
"+tweetDate.before(calendar.getTime()));
-                       return tweetDate.before(calendar.getTime());
+                       tweetDate = dateFormat.parse(dateAsString);
                } catch (ParseException e) {
-                       e.printStackTrace();
-               }
-        
-       return false;
+            logger.error("can't parse date " + dateAsString, e);
+            return false;
+        }
+
+        logger.debug("Older than an hour?: "+ 
tweetDate.before(calendar.getTime()));
+        return tweetDate.before(calendar.getTime());
        }
 
        @SuppressWarnings("rawtypes")
@@ -96,8 +98,7 @@ public class OpenEJBMessageFilterUtil {
         
                Integer retweetCount;
                try {
-                       retweetCount = null;
-                       retweetCount = getRetweetCount(keyValue, retweetCount);
+                       retweetCount = getRetweetCount(keyValue, null);
                } catch (NumberFormatException ignoredException) {
                        //Sometimes retweet-count returned by twitter is "100+" 
A non Number.
                        //Ignoring such exception
@@ -105,11 +106,7 @@ public class OpenEJBMessageFilterUtil {
                        return true;
                }        
                
-               if (retweetCount > 0) {
-            return true;
-        } else {
-            return false;
-        }
+               return retweetCount > 0;
     }
 
        @SuppressWarnings("rawtypes")

Modified: 
openejb/trunk/sandbox/tools/src/main/java/org/apache/openejb/tools/twitter/RetweetAppConstants.java
URL: 
http://svn.apache.org/viewvc/openejb/trunk/sandbox/tools/src/main/java/org/apache/openejb/tools/twitter/RetweetAppConstants.java?rev=1135790&r1=1135789&r2=1135790&view=diff
==============================================================================
--- 
openejb/trunk/sandbox/tools/src/main/java/org/apache/openejb/tools/twitter/RetweetAppConstants.java
 (original)
+++ 
openejb/trunk/sandbox/tools/src/main/java/org/apache/openejb/tools/twitter/RetweetAppConstants.java
 Tue Jun 14 20:54:07 2011
@@ -16,9 +16,12 @@
  */
 package org.apache.openejb.tools.twitter;
 
-public class RetweetAppConstants {
+import java.util.Locale;
 
-       public static final String TWITTER_DATE_FORMAT="EEE MMM d H:m:s Z y";
-       public static final String 
USER_TIMELINE_STATUS_URL="http://api.twitter.com/1/statuses/user_timeline.json?include_rts=true&count=20&screen_name=";;
-       public static final String 
RETWEET_URL="http://api.twitter.com/1/statuses/retweet/";;
+public interface RetweetAppConstants {
+
+       static final String TWITTER_DATE_FORMAT="EEE MMM d H:m:s Z y";
+       static final Locale TWITTER_LOCALE = Locale.ENGLISH;
+       static final String 
USER_TIMELINE_STATUS_URL="http://api.twitter.com/1/statuses/user_timeline.json?include_rts=true&count=20&screen_name=";;
+       static final String 
RETWEET_URL="http://api.twitter.com/1/statuses/retweet/";;
 }