Author: vishwanathk
Date: Fri Aug 31 00:46:30 2012
New Revision: 1379241
URL: http://svn.apache.org/viewvc?rev=1379241&view=rev
Log:
TOMEE-408 Address sonar found violation: Call to equals() comparing different
types
Added:
openejb/trunk/openejb/container/openejb-core/src/test/java/org/apache/openejb/util/BeanTypeComparisonTest.java
Modified:
openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/core/BaseSessionContext.java
Modified:
openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/core/BaseSessionContext.java
URL:
http://svn.apache.org/viewvc/openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/core/BaseSessionContext.java?rev=1379241&r1=1379240&r2=1379241&view=diff
==============================================================================
---
openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/core/BaseSessionContext.java
(original)
+++
openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/core/BaseSessionContext.java
Fri Aug 31 00:46:30 2012
@@ -26,7 +26,6 @@ import org.apache.openejb.core.managed.M
import org.apache.openejb.core.singleton.SingletonEjbObjectHandler;
import org.apache.openejb.core.stateful.StatefulEjbObjectHandler;
import org.apache.openejb.core.stateless.StatelessEjbObjectHandler;
-import org.apache.openejb.jee.SessionType;
import org.apache.openejb.spi.SecurityService;
import org.apache.openejb.util.proxy.LocalBeanProxyFactory;
import org.apache.openejb.util.proxy.ProxyManager;
@@ -139,7 +138,7 @@ public abstract class BaseSessionContext
List<Class> interfaces = new ArrayList<Class>();
interfaces.addAll(di.getInterfaces(interfaceType));
interfaces.add(IntraVmProxy.class);
- if (SessionType.STATEFUL.equals(type) ||
SessionType.MANAGED.equals(type)) {
+ if (BeanType.STATEFUL.equals(type) ||
BeanType.MANAGED.equals(type)) {
interfaces.add(BeanContext.Removable.class);
}
return ProxyManager.newProxyInstance(interfaces.toArray(new
Class[interfaces.size()]), handler);
Added:
openejb/trunk/openejb/container/openejb-core/src/test/java/org/apache/openejb/util/BeanTypeComparisonTest.java
URL:
http://svn.apache.org/viewvc/openejb/trunk/openejb/container/openejb-core/src/test/java/org/apache/openejb/util/BeanTypeComparisonTest.java?rev=1379241&view=auto
==============================================================================
---
openejb/trunk/openejb/container/openejb-core/src/test/java/org/apache/openejb/util/BeanTypeComparisonTest.java
(added)
+++
openejb/trunk/openejb/container/openejb-core/src/test/java/org/apache/openejb/util/BeanTypeComparisonTest.java
Fri Aug 31 00:46:30 2012
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.openejb.util;
+
+import org.apache.openejb.BeanType;
+import org.apache.openejb.jee.SessionType;
+import org.junit.Test;
+
+import static org.junit.Assert.assertFalse;
+
+public class BeanTypeComparisonTest {
+
+ @Test
+ public void testEqualsMethodForDifferentClassTypes()
+ {
+ BeanType beanType= BeanType.STATELESS;
+ SessionType sessionType = SessionType.STATELESS;
+ assertFalse(beanType.equals(sessionType));
+ }
+
+
+
+
+}
