Author: rmannibucau Date: Wed Jan 9 00:59:57 2013 New Revision: 1430644 URL: http://svn.apache.org/viewvc?rev=1430644&view=rev Log: minor fix + moving logger creation from JULOpenJPALog to JULOpenJPALogFactory to be consistent with OpenJPA practise
Modified: openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/openjpa/JULOpenJPALog.java openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/openjpa/JULOpenJPALogFactory.java openejb/trunk/openejb/container/openejb-core/src/test/java/org/apache/openejb/bval/BeanValidationTest.java Modified: openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java URL: http://svn.apache.org/viewvc/openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java?rev=1430644&r1=1430643&r2=1430644&view=diff ============================================================================== --- openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java (original) +++ openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java Wed Jan 9 00:59:57 2013 @@ -185,7 +185,7 @@ public class Assembler extends Assembler static { AsmParameterNameLoader.install(); - //avoid linkage error on mac + // avoid linkage error on mac // adding just in case others run into in their tests JULLoggerFactory.class.getName(); } Modified: openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/openjpa/JULOpenJPALog.java URL: http://svn.apache.org/viewvc/openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/openjpa/JULOpenJPALog.java?rev=1430644&r1=1430643&r2=1430644&view=diff ============================================================================== --- openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/openjpa/JULOpenJPALog.java (original) +++ openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/openjpa/JULOpenJPALog.java Wed Jan 9 00:59:57 2013 @@ -26,8 +26,8 @@ import java.util.logging.Logger; public class JULOpenJPALog implements Log { private final Logger logger; - public JULOpenJPALog(final String channel) { - logger = Logger.getLogger(channel); + public JULOpenJPALog(final Logger delegate) { + logger = delegate; } @Override Modified: openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/openjpa/JULOpenJPALogFactory.java URL: http://svn.apache.org/viewvc/openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/openjpa/JULOpenJPALogFactory.java?rev=1430644&r1=1430643&r2=1430644&view=diff ============================================================================== --- openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/openjpa/JULOpenJPALogFactory.java (original) +++ openejb/trunk/openejb/container/openejb-core/src/main/java/org/apache/openejb/openjpa/JULOpenJPALogFactory.java Wed Jan 9 00:59:57 2013 @@ -19,9 +19,11 @@ package org.apache.openejb.openjpa; import org.apache.openjpa.lib.log.Log; import org.apache.openjpa.lib.log.LogFactoryAdapter; +import java.util.logging.Logger; + public class JULOpenJPALogFactory extends LogFactoryAdapter { @Override protected Log newLogAdapter(final String channel) { - return new JULOpenJPALog(channel); + return new JULOpenJPALog(Logger.getLogger(channel)); } } Modified: openejb/trunk/openejb/container/openejb-core/src/test/java/org/apache/openejb/bval/BeanValidationTest.java URL: http://svn.apache.org/viewvc/openejb/trunk/openejb/container/openejb-core/src/test/java/org/apache/openejb/bval/BeanValidationTest.java?rev=1430644&r1=1430643&r2=1430644&view=diff ============================================================================== --- openejb/trunk/openejb/container/openejb-core/src/test/java/org/apache/openejb/bval/BeanValidationTest.java (original) +++ openejb/trunk/openejb/container/openejb-core/src/test/java/org/apache/openejb/bval/BeanValidationTest.java Wed Jan 9 00:59:57 2013 @@ -78,13 +78,13 @@ public class BeanValidationTest { @Module public Persistence persistence() { - PersistenceUnit unit = new PersistenceUnit("foo-unit"); + final PersistenceUnit unit = new PersistenceUnit("foo-unit"); unit.addClass(EntityToValidate.class); unit.setProperty("openjpa.jdbc.SynchronizeMappings", "buildSchema(ForeignKeys=true)"); unit.getProperties().setProperty("openjpa.RuntimeUnenhancedClasses", "supported"); unit.setExcludeUnlistedClasses(true); - Persistence persistence = new Persistence(unit); + final Persistence persistence = new Persistence(unit); persistence.setVersion("2.0"); return persistence; }