Author: dwoods
Date: Wed Jun 16 20:56:15 2010
New Revision: 955379

URL: http://svn.apache.org/viewvc?rev=955379&view=rev
Log:
OPENJPA-1700 FindBugs - Call to equals() comparing different types.  Make 
explicit call to getName() instead of relying on toString() to call it.

Modified:
    
openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/meta/strats/ObjectIdValueHandler.java

Modified: 
openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/meta/strats/ObjectIdValueHandler.java
URL: 
http://svn.apache.org/viewvc/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/meta/strats/ObjectIdValueHandler.java?rev=955379&r1=955378&r2=955379&view=diff
==============================================================================
--- 
openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/meta/strats/ObjectIdValueHandler.java
 (original)
+++ 
openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/meta/strats/ObjectIdValueHandler.java
 Wed Jun 16 20:56:15 2010
@@ -138,7 +138,7 @@ public class ObjectIdValueHandler
     private boolean isReferenceField(FieldMapping fm, DBIdentifier refColName) 
{
         List cols = fm.getValueInfo().getColumns();
         if (cols.size() == 0) {
-            if (fm.getName().equals(refColName))
+            if (fm.getName().equals(refColName.getName()))
                 return true;                
         } else {
             if (((Column)cols.get(0)).getIdentifier().equals(refColName))


Reply via email to