svn commit: r1030932 - /openjpa/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/meta/XMLMetaDataSerializer.java

[curtisr7]

Author: curtisr7
Date: Thu Nov  4 13:17:10 2010
New Revision: 1030932

URL: http://svn.apache.org/viewvc?rev=1030932&view=rev
Log:
OPENJPA-1871: Fix FindBugs reported performance problem in 
XMLMetaDataSerializer. Patch contributed by Guy Korland.

Modified:
    
openjpa/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/meta/XMLMetaDataSerializer.java

Modified: 
openjpa/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/meta/XMLMetaDataSerializer.java
URL: 
http://svn.apache.org/viewvc/openjpa/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/meta/XMLMetaDataSerializer.java?rev=1030932&r1=1030931&r2=1030932&view=diff
==============================================================================
--- 
openjpa/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/meta/XMLMetaDataSerializer.java
 (original)
+++ 
openjpa/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/meta/XMLMetaDataSerializer.java
 Thu Nov  4 13:17:10 2010
@@ -27,10 +27,9 @@ import java.security.AccessController;
 import java.security.PrivilegedActionException;
 import java.util.Collection;
 import java.util.HashMap;
-import java.util.Iterator;
 import java.util.LinkedList;
-import java.util.List;
 import java.util.Map;
+import java.util.Map.Entry;
 
 import javax.xml.transform.Result;
 import javax.xml.transform.TransformerConfigurationException;
@@ -98,10 +97,10 @@ public abstract class XMLMetaDataSeriali
         if (files == null)
             return;
 
-        // for each file, serialize objects
-        Collection<Object> fileObjs; 
-        for(File file : files.keySet()) { 
-            fileObjs = files.get(file); 
+        // for each file, serialize objects 
+        for (Entry<File, Collection<Object>> entry : files.entrySet()) {
+            File file = entry.getKey();
+            Collection<Object> fileObjs = entry.getValue(); 
             if (_log != null && _log.isInfoEnabled())
                 _log.info(_loc.get("ser-file", file));