[ 
https://issues.apache.org/jira/browse/OPENMEETINGS-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13607392#comment-13607392
 ] 

Maxim Solodovnik commented on OPENMEETINGS-572:
-----------------------------------------------

Hello Ivan,

Thanks for the contribution
I have couple of comments:

0) please use tabs instead of spaces where possible
1) getNotNull is not the best function name, I believe the better name would be 
getNotNullString
2) the function is actually oneliner: "return val == null ? '' : val;" (you can 
skip adding CDATA since nothing break XML in this case)
3) instead of copy/pasting this function in multiple places it can be added to 
mainMethods.lzx and then called as canvas.getNotNullString()

Could you please update your patch with the above changes?
Thanks in advance
                
> Empty fields are replaced with string "null" after export&import
> ----------------------------------------------------------------
>
>                 Key: OPENMEETINGS-572
>                 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-572
>             Project: Openmeetings
>          Issue Type: Bug
>          Components: Import/Export
>    Affects Versions: 2.1 Apache Release
>            Reporter: Marius van Voorden
>            Assignee: Maxim Solodovnik
>            Priority: Minor
>         Attachments: bugfix_572.patch
>
>
> When I make a backup, and import it in a new build, empty user fields are 
> replaced with the string "null". Examples of fields that show this are 
> firstname, lastname, street, etc.
> OS: Windows. I don't know if this is OS-specific.
> DB: The default one. I don't know if this is DB-specific.
> Build: All the recent ones.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to