[
https://issues.apache.org/jira/browse/OPENMEETINGS-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621845#comment-13621845
]
Irina Arkhipets commented on OPENMEETINGS-560:
----------------------------------------------
Hello Ivan,
I've reviewed your patch and found that:
1). It does not take into account that duplicated, not-deleted records always
can exist in the database. I don't found any changes in the import/export
process in the patch.
If I have two duplicated not-deleted records, apply your patch and go to
Administration -> Configuration I am still able to successfully edit and save
changes of the duplicated record.
Making import-export before I apply your patch does not help and have the
same result.
2). After your patch was applied, I tried to create a record with the
duplicated key value. Yes, creating such a record is impossible now, but I get
two error message windows instead of one.
3). In your patch there are two copy-pasted places of the code - these are
hasKey and getDeletedConfiguration methods in ConfigurationDao.java file. I
believe you would be better to have one method with additional delete_flag
boolean parameter instead.
Best regards,
Irina.
> It’s possible to add several records with the same key value in configuration.
> ------------------------------------------------------------------------------
>
> Key: OPENMEETINGS-560
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-560
> Project: Openmeetings
> Issue Type: Bug
> Affects Versions: 2.1.0 Apache Release
> Reporter: Irina Arkhipets
> Priority: Minor
> Fix For: 3.0.0 Apache Release
>
> Attachments: bugfix_560.patch
>
>
> How to reproduce:
> Log into OpenMeetings as admin
> Go to “Administration” -> “Configuration”
> Add some new value for the key which already exists in the table (for
> example, default_group_id)
> Result: It’s possible to have two values for the same key.
> Expected result: conf_key in the conference table should be unique, it can
> cause unexpected side effects otherwise
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
