svn commit: r1758358 - in /openmeetings/application: branches/3.2.x/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/red5/ trunk/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/red5/

[solomax]

Author: solomax
Date: Tue Aug 30 10:55:22 2016
New Revision: 1758358

URL: http://svn.apache.org/viewvc?rev=1758358&view=rev
Log:
[OPENMEETINGS-895] reject messages are added to the log

Modified:
    
openmeetings/application/branches/3.2.x/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/red5/ScopeApplicationAdapter.java
    
openmeetings/application/trunk/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/red5/ScopeApplicationAdapter.java

Modified: 
openmeetings/application/branches/3.2.x/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/red5/ScopeApplicationAdapter.java
URL: 
http://svn.apache.org/viewvc/openmeetings/application/branches/3.2.x/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/red5/ScopeApplicationAdapter.java?rev=1758358&r1=1758357&r2=1758358&view=diff
==============================================================================
--- 
openmeetings/application/branches/3.2.x/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/red5/ScopeApplicationAdapter.java
 (original)
+++ 
openmeetings/application/branches/3.2.x/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/red5/ScopeApplicationAdapter.java
 Tue Aug 30 10:55:22 2016
@@ -189,10 +189,12 @@ public class ScopeApplicationAdapter ext
                        //FIXME TODO add better mechanism, this is for external 
applications like ffmpeg
                        Client parent = 
sessionManager.getClientByPublicSID(securityCode, null);
                        if (parent == null || 
!parent.getScope().equals(conn.getScope().getName())) {
+                               log.warn("Security code is invalid, client is 
rejected");
                                return rejectClient();
                        }
                }
                if (Strings.isEmpty(uid) && Strings.isEmpty(securityCode) && 
Strings.isEmpty(parentSid)) {
+                       log.warn("No UIDs are provided, client is rejected");
                        return rejectClient();
                }
                if ("networktest".equals(uid)) {
@@ -205,6 +207,7 @@ public class ScopeApplicationAdapter ext
                if (map.containsKey("screenClient")) {
                        parentClient = 
sessionManager.getClientByPublicSID(parentSid, null);
                        if (parentClient == null) {
+                               log.warn("Bad parent for screen-sharing client, 
client is rejected");
                                return rejectClient();
                        }
                        
SessionVariablesUtil.setIsScreenClient(conn.getClient());
@@ -220,6 +223,7 @@ public class ScopeApplicationAdapter ext
                if (Long.MIN_VALUE != roomId) {
                        rcm.setRoomId(roomId);
                } else if (!"hibernate".equals(scn.toString())) {
+                       log.warn("Bad room specified, client is rejected");
                        return rejectClient();
                }
                rcm.setUserport(conn.getRemotePort());

Modified: 
openmeetings/application/trunk/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/red5/ScopeApplicationAdapter.java
URL: 
http://svn.apache.org/viewvc/openmeetings/application/trunk/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/red5/ScopeApplicationAdapter.java?rev=1758358&r1=1758357&r2=1758358&view=diff
==============================================================================
--- 
openmeetings/application/trunk/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/red5/ScopeApplicationAdapter.java
 (original)
+++ 
openmeetings/application/trunk/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/red5/ScopeApplicationAdapter.java
 Tue Aug 30 10:55:22 2016
@@ -189,10 +189,12 @@ public class ScopeApplicationAdapter ext
                        //FIXME TODO add better mechanism, this is for external 
applications like ffmpeg
                        Client parent = 
sessionManager.getClientByPublicSID(securityCode, null);
                        if (parent == null || 
!parent.getScope().equals(conn.getScope().getName())) {
+                               log.warn("Security code is invalid, client is 
rejected");
                                return rejectClient();
                        }
                }
                if (Strings.isEmpty(uid) && Strings.isEmpty(securityCode) && 
Strings.isEmpty(parentSid)) {
+                       log.warn("No UIDs are provided, client is rejected");
                        return rejectClient();
                }
                if ("networktest".equals(uid)) {
@@ -205,6 +207,7 @@ public class ScopeApplicationAdapter ext
                if (map.containsKey("screenClient")) {
                        parentClient = 
sessionManager.getClientByPublicSID(parentSid, null);
                        if (parentClient == null) {
+                               log.warn("Bad parent for screen-sharing client, 
client is rejected");
                                return rejectClient();
                        }
                        
SessionVariablesUtil.setIsScreenClient(conn.getClient());
@@ -220,6 +223,7 @@ public class ScopeApplicationAdapter ext
                if (Long.MIN_VALUE != roomId) {
                        rcm.setRoomId(roomId);
                } else if (!"hibernate".equals(scn.toString())) {
+                       log.warn("Bad room specified, client is rejected");
                        return rejectClient();
                }
                rcm.setUserport(conn.getRemotePort());