Repository: openmeetings Updated Branches: refs/heads/master 10e64c047 -> 5b45b33b9
[OPENMEETINGS-1714] coverage is improved Project: http://git-wip-us.apache.org/repos/asf/openmeetings/repo Commit: http://git-wip-us.apache.org/repos/asf/openmeetings/commit/5b45b33b Tree: http://git-wip-us.apache.org/repos/asf/openmeetings/tree/5b45b33b Diff: http://git-wip-us.apache.org/repos/asf/openmeetings/diff/5b45b33b Branch: refs/heads/master Commit: 5b45b33b9e7aa9a1b2a0003aa7c25af0977cd9bd Parents: 10e64c0 Author: Maxim Solodovnik <[email protected]> Authored: Mon Oct 9 14:24:41 2017 +0700 Committer: Maxim Solodovnik <[email protected]> Committed: Mon Oct 9 14:24:41 2017 +0700 ---------------------------------------------------------------------- .../org/apache/openmeetings/db/dao/TestRoomDao.java | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/openmeetings/blob/5b45b33b/openmeetings-web/src/test/java/org/apache/openmeetings/db/dao/TestRoomDao.java ---------------------------------------------------------------------- diff --git a/openmeetings-web/src/test/java/org/apache/openmeetings/db/dao/TestRoomDao.java b/openmeetings-web/src/test/java/org/apache/openmeetings/db/dao/TestRoomDao.java index 40b96cc..717b687 100644 --- a/openmeetings-web/src/test/java/org/apache/openmeetings/db/dao/TestRoomDao.java +++ b/openmeetings-web/src/test/java/org/apache/openmeetings/db/dao/TestRoomDao.java @@ -18,6 +18,7 @@ */ package org.apache.openmeetings.db.dao; +import static org.apache.openmeetings.util.OpenmeetingsVariables.getWebAppRootKey; import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertTrue; @@ -27,11 +28,14 @@ import org.apache.openmeetings.db.dao.room.RoomDao; import org.apache.openmeetings.db.entity.room.Room; import org.apache.openmeetings.db.entity.room.Room.RoomElement; import org.apache.openmeetings.db.entity.user.User; +import org.junit.Assert; import org.junit.Test; +import org.red5.logging.Red5LoggerFactory; +import org.slf4j.Logger; import org.springframework.beans.factory.annotation.Autowired; - public class TestRoomDao extends AbstractJUnitDefaults { + private static final Logger log = Red5LoggerFactory.getLogger(TestRoomDao.class, getWebAppRootKey()); @Autowired protected RoomDao roomDao; @@ -47,6 +51,11 @@ public class TestRoomDao extends AbstractJUnitDefaults { User u = userDao.getByLogin(adminUsername, User.Type.user, null); assertNotNull("Admin user should exist", u); r = roomDao.getUserRoom(u.getId(), Room.Type.presentation, "bla"); - assertTrue("User presentation room should have mic status hidden", r.isHidden(RoomElement.MicrophoneStatus)); + boolean hidden = r.isHidden(RoomElement.MicrophoneStatus); + if (!hidden && log.isDebugEnabled()) { + log.debug("Invalid personal room found -> User: {}, Room: {} ... deleted ? {}", u, r, r.isDeleted()); + } + Assert.assertEquals("User presentation room should be created", Room.Type.presentation, r.getType()); + assertTrue("User presentation room should have mic status hidden", hidden); } }
