[
https://issues.apache.org/jira/browse/OPENMEETINGS-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16671353#comment-16671353
]
ASF GitHub Bot commented on OPENMEETINGS-1636:
----------------------------------------------
solomax commented on a change in pull request #12: OPENMEETINGS-1636 Upgrade
Caldav4j to 1.0.0-rc.1
URL: https://github.com/apache/openmeetings/pull/12#discussion_r229983228
##########
File path:
openmeetings-service/src/main/java/org/apache/openmeetings/service/calendar/caldav/IcalUtils.java
##########
@@ -217,7 +218,9 @@ private Appointment
addVEventPropertiestoAppointment(Appointment a, CalendarComp
}
}
- List<MeetingMember> attList = a.getMeetingMembers() == null ?
new ArrayList<>() : a.getMeetingMembers();
+ HashSet<MeetingMember> attList = a.getMeetingMembers() == null
? new HashSet<>()
Review comment:
I would change it to be `Set<MeetingMember> attList` unless you are using
methods specific to `HashSet` later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Upgrade AppointmentManager from HttpClient 3.x to 4.x
> -----------------------------------------------------
>
> Key: OPENMEETINGS-1636
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-1636
> Project: Openmeetings
> Issue Type: Improvement
> Components: HTML5/Calendar
> Reporter: Ankush Mishra
> Assignee: Ankush Mishra
> Priority: Minor
> Fix For: 4.0.7
>
>
> I had been waiting for
> [JCR-2406|https://issues.apache.org/jira/browse/JCR-2406] to close. Since,
> that has been completed for a couple of months, I opened another Issue for
> CalDAV4j [here|https://github.com/caldav4j/caldav4j/issues/63] , which I will
> try to first release to the Central Repo soon, with 3.x, after which I will
> get to work on the migration.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
