[ https://issues.apache.org/jira/browse/OPENMEETINGS-2307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093116#comment-17093116 ]
ASF subversion and git services commented on OPENMEETINGS-2307: --------------------------------------------------------------- Commit 4744f5d19755d2824fdef9c4fd993c6cdc76cf55 in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=4744f5d ] Merge pull request #69 from apache/feature/OPENMEETINGS-2307-enable-checkstyle-with-simplest-rule-set OPENMEETINGS-2307 Add checkstyle check with simplistic checks > Enable Maven-checkstyle-plugin > ------------------------------ > > Key: OPENMEETINGS-2307 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2307 > Project: Openmeetings > Issue Type: Improvement > Components: Builds > Affects Versions: 5.0.0-M4 > Reporter: Sebastian Wagner > Assignee: Sebastian Wagner > Priority: Major > Fix For: 5.0.0-M5 > > > I noticed that I don't get any build errors or warnings with unused imports. > I thought there is a checkstyle plugin running as part of Apache reports. > But there isn't. > There is a plugin here: > [http://maven.apache.org/plugins/maven-checkstyle-plugin/index.html] > I think it reveals a lot of useful information. Doesn't mean we fix all of > it. But its very helpful. > It may also generate a nice report: > [http://maven.apache.org/plugins-archives/maven-project-info-reports-plugin-LATEST/checkstyle.html] > Which can be useful once more people work on code, so you don't need to > review syntax and code smells in every PR manually. -- This message was sent by Atlassian Jira (v8.3.4#803005)