[openmeetings] branch feature/OPENMEETINGS-2580-re-apply-ice-before-sending-ws-candidates updated: OPENMEETINGS-2580 Externalise method.

[sebawagner]

This is an automated email from the ASF dual-hosted git repository.

sebawagner pushed a commit to branch 
feature/OPENMEETINGS-2580-re-apply-ice-before-sending-ws-candidates
in repository https://gitbox.apache.org/repos/asf/openmeetings.git


The following commit(s) were added to 
refs/heads/feature/OPENMEETINGS-2580-re-apply-ice-before-sending-ws-candidates 
by this push:
     new f7b743e  OPENMEETINGS-2580 Externalise method.
f7b743e is described below

commit f7b743e75af56d250f735ca566df650e22d01bc6
Author: Sebastian Wagner <seba.wag...@gmail.com>
AuthorDate: Thu Feb 25 09:50:20 2021 +1300

    OPENMEETINGS-2580 Externalise method.
---
 .../org/apache/openmeetings/core/remote/KStream.java | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git 
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KStream.java
 
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KStream.java
index bfe7175..694fc1f 100644
--- 
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KStream.java
+++ 
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KStream.java
@@ -308,15 +308,7 @@ public class KStream extends AbstractStream implements 
ISipCallbacks {
        private WebRtcEndpoint createEndpoint(String sid, String uid, boolean 
recv) {
                WebRtcEndpoint endpoint = createWebRtcEndpoint(pipeline, recv);
                setTags(endpoint, uid);
-
-               if (recv) {
-                       if (!candidatesQueue.isEmpty()) {
-                               log.trace("addIceCandidate iceCandidate reply 
from not ready, uid: {}", uid);
-                               candidatesQueue.stream()
-                                       .forEach(candidate -> 
endpoint.addIceCandidate(candidate));
-                               candidatesQueue.clear();
-                       }
-               }
+               reApplyIceCandiates(endpoint, recv);
 
                endpoint.addIceCandidateFoundListener(evt -> 
kHandler.sendClient(sid
                                , newKurentoMsg()
@@ -327,6 +319,16 @@ public class KStream extends AbstractStream implements 
ISipCallbacks {
                return endpoint;
        }
 
+       private void reApplyIceCandiates(WebRtcEndpoint endpoint, boolean recv) 
{
+               // sender candidates
+               if (recv && !candidatesQueue.isEmpty()) {
+                               log.trace("addIceCandidate iceCandidate reply 
from not ready, uid: {}", uid);
+                               candidatesQueue.stream()
+                                       .forEach(candidate -> 
endpoint.addIceCandidate(candidate));
+                               candidatesQueue.clear();
+               }
+       }
+
        public void startRecord() {
                log.debug("startRecord outMedia OK ? {}", outgoingMedia != 
null);
                if (outgoingMedia == null) {