This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new 854d7a477 [OPENMEETINGS-2792] attempt to find broken test
854d7a477 is described below
commit 854d7a4779434ccbeb4ab8d621eb1ec9c091c292
Author: Maxim Solodovnik <[email protected]>
AuthorDate: Mon Sep 8 09:03:28 2025 +0700
[OPENMEETINGS-2792] attempt to find broken test
---
.../core/util/StrongPasswordValidator.java | 9 ++++++---
.../openmeetings/web/pages/auth/TestLoginUI.java | 20 +++++++++++++++++++-
openmeetings-web/src/test/resources/logback-test.xml | 1 +
3 files changed, 26 insertions(+), 4 deletions(-)
diff --git
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/util/StrongPasswordValidator.java
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/util/StrongPasswordValidator.java
index 234e4b428..c06ba830a 100644
---
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/util/StrongPasswordValidator.java
+++
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/util/StrongPasswordValidator.java
@@ -74,9 +74,12 @@ public class StrongPasswordValidator implements
IValidator<String> {
if (Strings.isEmpty(password) || Strings.isEmpty(word) ||
word.length() < 3) {
return false;
}
- for (int i = 0; i < word.length() - 3; ++i) {
- String substr =
word.toLowerCase(Locale.ROOT).substring(i, i + 3);
- if (password.toLowerCase(Locale.ROOT).indexOf(substr) >
-1) {
+ final String lword = word.toLowerCase(Locale.ROOT);
+ final String lpwd = password.toLowerCase(Locale.ROOT);
+ for (int i = 0; i < lword.length() - 3; ++i) {
+ String substr = lword.substring(i, i + 3);
+ if (lpwd.indexOf(substr) > -1) {
+ log.trace("Part '{}' of '{}' [{}] found in pwd
'{}' []", substr, lword, word, lpwd, password);
return true;
}
}
diff --git
a/openmeetings-web/src/test/java/org/apache/openmeetings/web/pages/auth/TestLoginUI.java
b/openmeetings-web/src/test/java/org/apache/openmeetings/web/pages/auth/TestLoginUI.java
index 6d83d916b..0b91f3843 100644
---
a/openmeetings-web/src/test/java/org/apache/openmeetings/web/pages/auth/TestLoginUI.java
+++
b/openmeetings-web/src/test/java/org/apache/openmeetings/web/pages/auth/TestLoginUI.java
@@ -48,8 +48,11 @@ import org.apache.wicket.util.tester.FormTester;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.ValueSource;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
class TestLoginUI extends AbstractWicketTesterTest {
+ private static final Logger log =
LoggerFactory.getLogger(TestLoginUI.class);
private static final String PATH_REGISTER = "register:form";
private void checkLogin(String login, String pass) {
@@ -109,6 +112,19 @@ class TestLoginUI extends AbstractWicketTesterTest {
assertTrue(countErrors(tester) > 7, "There should be at least 8
errors");
}
+ @Test
+ void testBadEmailRegister2Err() throws ReflectiveOperationException,
SecurityException {
+ final Locale l = Locale.forLanguageTag("pt-TL");
+ log.info("Owerriding locale to: {}", l);
+ tester.getSession().setLocale(l);
+ String email = "gggg\n@hhhh";
+ String uid = "1ca45f9c-7761-403a-a9da-c38bcaaeb0e2";
+ performRegister(uid, email, 1, "account.created");
+ FormTester formTester = showRegister();
+ formTester.submit("submit");
+ assertTrue(countErrors(tester) > 7, "There should be at least 8
errors");
+ }
+
@Test
void testRegister() throws ReflectiveOperationException,
SecurityException {
String uid = randomUUID().toString();
@@ -167,7 +183,9 @@ class TestLoginUI extends AbstractWicketTesterTest {
private void performRegister(String uid, String emailToTest, int
errorsExpected, String lbl) throws ReflectiveOperationException,
SecurityException {
FormTester formTester = showRegister();
- formTester.setValue("login", getLogin(uid));
+ final String login = getLogin(uid);
+ log.info("Performing register: login = '{}', email = '{}', pwd
= '{}'", login, emailToTest, USER_PASS);
+ formTester.setValue("login", login);
formTester.setValue("email", emailToTest);
formTester.setValue("firstName", "first" + uid);
formTester.setValue("lastName", "last" + uid);
diff --git a/openmeetings-web/src/test/resources/logback-test.xml
b/openmeetings-web/src/test/resources/logback-test.xml
index 2db16c09b..eff3cbad9 100644
--- a/openmeetings-web/src/test/resources/logback-test.xml
+++ b/openmeetings-web/src/test/resources/logback-test.xml
@@ -48,6 +48,7 @@
<logger name="org.apache.openmeetings" level="DEBUG" />
<logger name="org.apache.cxf.services" level="DEBUG" /> <!-- for
payload -->
<logger name="org.apache.openmeetings.core.remote.KurentoHandler"
level="ERROR" /> <!-- no warn -->
+ <logger name="org.apache.openmeetings.core.util" level="TRACE" />
<root level="INFO">
<appender-ref ref="FILE" />
<appender-ref ref="CONSOLE" />
