Remove duplicate if in if The inner if is identical and will always have the same result as the outer one.
See issue OPENNLP-871 Project: http://git-wip-us.apache.org/repos/asf/opennlp/repo Commit: http://git-wip-us.apache.org/repos/asf/opennlp/commit/3ab16184 Tree: http://git-wip-us.apache.org/repos/asf/opennlp/tree/3ab16184 Diff: http://git-wip-us.apache.org/repos/asf/opennlp/diff/3ab16184 Branch: refs/heads/trunk Commit: 3ab16184657e381a69c3415fed76711147c4e0cf Parents: cd6b11d Author: Jörn Kottmann <[email protected]> Authored: Wed Nov 2 19:36:59 2016 +0100 Committer: Jörn Kottmann <[email protected]> Committed: Mon Dec 19 23:37:32 2016 +0100 ---------------------------------------------------------------------- .../src/main/java/opennlp/tools/util/model/BaseModel.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/opennlp/blob/3ab16184/opennlp-tools/src/main/java/opennlp/tools/util/model/BaseModel.java ---------------------------------------------------------------------- diff --git a/opennlp-tools/src/main/java/opennlp/tools/util/model/BaseModel.java b/opennlp-tools/src/main/java/opennlp/tools/util/model/BaseModel.java index 4a40d15..771958f 100644 --- a/opennlp-tools/src/main/java/opennlp/tools/util/model/BaseModel.java +++ b/opennlp-tools/src/main/java/opennlp/tools/util/model/BaseModel.java @@ -311,9 +311,7 @@ public abstract class BaseModel implements ArtifactProvider, Serializable { getManifestProperty(SERIALIZER_CLASS_NAME_PREFIX + entryName); if (artifactSerializerClazzName != null) { - if (artifactSerializerClazzName != null) { - factory = ExtensionLoader.instantiateExtension(ArtifactSerializer.class, artifactSerializerClazzName); - } + factory = ExtensionLoader.instantiateExtension(ArtifactSerializer.class, artifactSerializerClazzName); } if (factory != null) {
