This is an automated email from the ASF dual-hosted git repository.
tommaso pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/opennlp.git
The following commit(s) were added to refs/heads/master by this push:
new 50b126d OPENNLP-1169 - WVTable fetches WVs by String (#297)
50b126d is described below
commit 50b126dc0eb075a2193b670eb7ae2089896ba283
Author: Tommaso Teofili <[email protected]>
AuthorDate: Mon Dec 18 14:43:00 2017 +0100
OPENNLP-1169 - WVTable fetches WVs by String (#297)
---
.../main/java/opennlp/tools/util/wordvector/DoubleArrayVector.java | 2 +-
.../main/java/opennlp/tools/util/wordvector/FloatArrayVector.java | 2 +-
.../src/main/java/opennlp/tools/util/wordvector/Glove.java | 6 +++---
.../main/java/opennlp/tools/util/wordvector/MapWordVectorTable.java | 4 ++--
.../main/java/opennlp/tools/util/wordvector/WordVectorTable.java | 2 +-
5 files changed, 8 insertions(+), 8 deletions(-)
diff --git
a/opennlp-tools/src/main/java/opennlp/tools/util/wordvector/DoubleArrayVector.java
b/opennlp-tools/src/main/java/opennlp/tools/util/wordvector/DoubleArrayVector.java
index 79d03a3..e00ab80 100644
---
a/opennlp-tools/src/main/java/opennlp/tools/util/wordvector/DoubleArrayVector.java
+++
b/opennlp-tools/src/main/java/opennlp/tools/util/wordvector/DoubleArrayVector.java
@@ -22,7 +22,7 @@ import java.nio.FloatBuffer;
class DoubleArrayVector implements WordVector {
- private double[] vector;
+ private final double[] vector;
DoubleArrayVector(double[] vector) {
this.vector = vector;
diff --git
a/opennlp-tools/src/main/java/opennlp/tools/util/wordvector/FloatArrayVector.java
b/opennlp-tools/src/main/java/opennlp/tools/util/wordvector/FloatArrayVector.java
index 0ee7287..a0fd13e 100644
---
a/opennlp-tools/src/main/java/opennlp/tools/util/wordvector/FloatArrayVector.java
+++
b/opennlp-tools/src/main/java/opennlp/tools/util/wordvector/FloatArrayVector.java
@@ -22,7 +22,7 @@ import java.nio.FloatBuffer;
class FloatArrayVector implements WordVector {
- private float[] vector;
+ private final float[] vector;
FloatArrayVector(float[] vector) {
this.vector = vector;
diff --git
a/opennlp-tools/src/main/java/opennlp/tools/util/wordvector/Glove.java
b/opennlp-tools/src/main/java/opennlp/tools/util/wordvector/Glove.java
index c0c4053..91c2ff1 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/util/wordvector/Glove.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/util/wordvector/Glove.java
@@ -43,9 +43,9 @@ public class Glove {
* <p>
* Warning: Experimental new feature, see OPENNLP-1144 for details, the API
might be changed anytime.
*
- * @param in
- * @return
- * @throws IOException
+ * @param in the input stream for Glove vectors
+ * @return a Glove based wv table
+ * @throws IOException if any error occurs during parsing
*/
@Experimental
public static WordVectorTable parse(InputStream in) throws IOException {
diff --git
a/opennlp-tools/src/main/java/opennlp/tools/util/wordvector/MapWordVectorTable.java
b/opennlp-tools/src/main/java/opennlp/tools/util/wordvector/MapWordVectorTable.java
index 83776d8..763a69c 100644
---
a/opennlp-tools/src/main/java/opennlp/tools/util/wordvector/MapWordVectorTable.java
+++
b/opennlp-tools/src/main/java/opennlp/tools/util/wordvector/MapWordVectorTable.java
@@ -28,8 +28,8 @@ class MapWordVectorTable implements WordVectorTable {
}
@Override
- public WordVector get(CharSequence token) {
- return vectors.get(token.toString());
+ public WordVector get(String token) {
+ return vectors.get(token);
}
@Override
diff --git
a/opennlp-tools/src/main/java/opennlp/tools/util/wordvector/WordVectorTable.java
b/opennlp-tools/src/main/java/opennlp/tools/util/wordvector/WordVectorTable.java
index 17c347a..5d55107 100644
---
a/opennlp-tools/src/main/java/opennlp/tools/util/wordvector/WordVectorTable.java
+++
b/opennlp-tools/src/main/java/opennlp/tools/util/wordvector/WordVectorTable.java
@@ -28,7 +28,7 @@ import opennlp.tools.util.java.Experimental;
@Experimental
public interface WordVectorTable {
- WordVector get(CharSequence token);
+ WordVector get(String token);
int size();
--
To stop receiving notification emails like this one, please contact
['"[email protected]" <[email protected]>'].
