This is an automated email from the ASF dual-hosted git repository.
koji pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/opennlp.git
The following commit(s) were added to refs/heads/master by this push:
new 49cb9f5 OPENNLP-1212: TokenFeatureGeneratorFactory doesn't allow us
to set lowercase flag (#327)
49cb9f5 is described below
commit 49cb9f597c9516ebfcc2c4f477ded3d012858024
Author: Koji Sekiguchi <[email protected]>
AuthorDate: Tue Aug 14 07:22:42 2018 +0900
OPENNLP-1212: TokenFeatureGeneratorFactory doesn't allow us to set
lowercase flag (#327)
---
.../opennlp/tools/util/featuregen/TokenFeatureGeneratorFactory.java | 2 +-
.../main/resources/opennlp/tools/namefind/ner-default-features.xml | 4 +++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git
a/opennlp-tools/src/main/java/opennlp/tools/util/featuregen/TokenFeatureGeneratorFactory.java
b/opennlp-tools/src/main/java/opennlp/tools/util/featuregen/TokenFeatureGeneratorFactory.java
index 20612f5..6660305 100644
---
a/opennlp-tools/src/main/java/opennlp/tools/util/featuregen/TokenFeatureGeneratorFactory.java
+++
b/opennlp-tools/src/main/java/opennlp/tools/util/featuregen/TokenFeatureGeneratorFactory.java
@@ -44,6 +44,6 @@ public class TokenFeatureGeneratorFactory
@Override
public AdaptiveFeatureGenerator create() throws InvalidFormatException {
- return new TokenFeatureGenerator();
+ return new TokenFeatureGenerator(getBool("lowercase", true));
}
}
diff --git
a/opennlp-tools/src/main/resources/opennlp/tools/namefind/ner-default-features.xml
b/opennlp-tools/src/main/resources/opennlp/tools/namefind/ner-default-features.xml
index 1f60ad1..d95549f 100644
---
a/opennlp-tools/src/main/resources/opennlp/tools/namefind/ner-default-features.xml
+++
b/opennlp-tools/src/main/resources/opennlp/tools/namefind/ner-default-features.xml
@@ -27,7 +27,9 @@
<generator
class="opennlp.tools.util.featuregen.WindowFeatureGeneratorFactory">
<int name="prevLength">2</int>
<int name="nextLength">2</int>
- <generator
class="opennlp.tools.util.featuregen.TokenFeatureGeneratorFactory"/>
+ <generator
class="opennlp.tools.util.featuregen.TokenFeatureGeneratorFactory">
+ <bool name="lowercase">true</bool>
+ </generator>
</generator>
<generator
class="opennlp.tools.util.featuregen.DefinitionFeatureGeneratorFactory"/>
<generator
class="opennlp.tools.util.featuregen.PreviousMapFeatureGeneratorFactory"/>