This is an automated email from the ASF dual-hosted git repository. mawiesne pushed a commit to branch OPENNLP-1465_Clear_out_unnecessary_semicolons_from_existing_classes in repository https://gitbox.apache.org/repos/asf/opennlp.git
commit d0b1a86e4d7dc6d3944457af88b29e2b709f985e Author: Martin Wiesner <[email protected]> AuthorDate: Fri Feb 17 22:05:55 2023 +0100 OPENNLP-1465 Clear out unnecessary semicolons from existing classes --- .../src/main/java/opennlp/tools/cmdline/parser/ModelUpdaterTool.java | 1 - .../src/main/java/opennlp/tools/util/TrainingParameters.java | 2 +- .../java/opennlp/tools/util/featuregen/AdaptiveFeatureGenerator.java | 4 ++-- .../src/main/java/opennlp/tools/util/wordvector/WordVectorType.java | 2 +- .../test/java/opennlp/tools/formats/letsmt/LetsmtDocumentTest.java | 2 +- .../test/java/opennlp/tools/ml/maxent/quasinewton/QNTrainerTest.java | 1 - .../java/opennlp/tools/ml/naivebayes/NaiveBayesCorrectnessTest.java | 1 - .../opennlp/tools/ml/naivebayes/NaiveBayesModelReadWriteTest.java | 1 - .../tools/ml/naivebayes/NaiveBayesSerializedCorrectnessTest.java | 1 - 9 files changed, 5 insertions(+), 10 deletions(-) diff --git a/opennlp-tools/src/main/java/opennlp/tools/cmdline/parser/ModelUpdaterTool.java b/opennlp-tools/src/main/java/opennlp/tools/cmdline/parser/ModelUpdaterTool.java index b61ec9a8..eed00f62 100644 --- a/opennlp-tools/src/main/java/opennlp/tools/cmdline/parser/ModelUpdaterTool.java +++ b/opennlp-tools/src/main/java/opennlp/tools/cmdline/parser/ModelUpdaterTool.java @@ -59,7 +59,6 @@ abstract class ModelUpdaterTool ObjectStreamFactory<Parse,ModelUpdaterParams> factory = getStreamFactory(format); String[] fargs = ArgumentParser.filter(args, factory.getParameters()); validateFactoryArgs(factory, fargs); - ; ParserModel updatedParserModel; try (ObjectStream<Parse> sampleStream = factory.create(fargs)) { diff --git a/opennlp-tools/src/main/java/opennlp/tools/util/TrainingParameters.java b/opennlp-tools/src/main/java/opennlp/tools/util/TrainingParameters.java index a54e0f84..824d6a04 100644 --- a/opennlp-tools/src/main/java/opennlp/tools/util/TrainingParameters.java +++ b/opennlp-tools/src/main/java/opennlp/tools/util/TrainingParameters.java @@ -158,7 +158,7 @@ public class TrainingParameters { for (Entry<String, Object> entry: settings.entrySet()) { String key = entry.getKey(); - Object value = entry.getValue();; + Object value = entry.getValue(); if (value instanceof Integer) { params.put(key, (Integer)value); } diff --git a/opennlp-tools/src/main/java/opennlp/tools/util/featuregen/AdaptiveFeatureGenerator.java b/opennlp-tools/src/main/java/opennlp/tools/util/featuregen/AdaptiveFeatureGenerator.java index d8c944a3..a5409848 100644 --- a/opennlp-tools/src/main/java/opennlp/tools/util/featuregen/AdaptiveFeatureGenerator.java +++ b/opennlp-tools/src/main/java/opennlp/tools/util/featuregen/AdaptiveFeatureGenerator.java @@ -51,11 +51,11 @@ public interface AdaptiveFeatureGenerator { * @param tokens The tokens of the sentence or other text unit which has been processed. * @param outcomes The outcomes associated with the specified tokens. */ - default void updateAdaptiveData(String[] tokens, String[] outcomes) {}; + default void updateAdaptiveData(String[] tokens, String[] outcomes) {} /** * Informs a feature generator that the context of the adaptive data (typically a document) * is no longer valid. */ - default void clearAdaptiveData() {}; + default void clearAdaptiveData() {} } diff --git a/opennlp-tools/src/main/java/opennlp/tools/util/wordvector/WordVectorType.java b/opennlp-tools/src/main/java/opennlp/tools/util/wordvector/WordVectorType.java index 0e526526..b848054e 100644 --- a/opennlp-tools/src/main/java/opennlp/tools/util/wordvector/WordVectorType.java +++ b/opennlp-tools/src/main/java/opennlp/tools/util/wordvector/WordVectorType.java @@ -22,5 +22,5 @@ import opennlp.tools.util.java.Experimental; @Experimental public enum WordVectorType { FLOAT, - DOUBLE; + DOUBLE } diff --git a/opennlp-tools/src/test/java/opennlp/tools/formats/letsmt/LetsmtDocumentTest.java b/opennlp-tools/src/test/java/opennlp/tools/formats/letsmt/LetsmtDocumentTest.java index 138601e8..e3fa7465 100644 --- a/opennlp-tools/src/test/java/opennlp/tools/formats/letsmt/LetsmtDocumentTest.java +++ b/opennlp-tools/src/test/java/opennlp/tools/formats/letsmt/LetsmtDocumentTest.java @@ -30,7 +30,7 @@ public class LetsmtDocumentTest extends AbstractFormatTest { @Test void testParsingSimpleDoc() throws IOException { - try (InputStream letsmtXmlIn = getResourceStream("letsmt/letsmt-with-words.xml");) { + try (InputStream letsmtXmlIn = getResourceStream("letsmt/letsmt-with-words.xml")) { LetsmtDocument doc = LetsmtDocument.parse(letsmtXmlIn); diff --git a/opennlp-tools/src/test/java/opennlp/tools/ml/maxent/quasinewton/QNTrainerTest.java b/opennlp-tools/src/test/java/opennlp/tools/ml/maxent/quasinewton/QNTrainerTest.java index 2deb71e2..afcf5e45 100644 --- a/opennlp-tools/src/test/java/opennlp/tools/ml/maxent/quasinewton/QNTrainerTest.java +++ b/opennlp-tools/src/test/java/opennlp/tools/ml/maxent/quasinewton/QNTrainerTest.java @@ -69,7 +69,6 @@ public class QNTrainerTest { RealValueFileEventStream rvfes1 = new RealValueFileEventStream( "src/test/resources/data/opennlp/maxent/real-valued-weights-training-data.txt"); testDataIndexer.index(rvfes1); - ; // when QNModel trainedModel = new QNTrainer(15, true).trainModel(ITERATIONS, testDataIndexer); String[] features2Classify = new String[] { diff --git a/opennlp-tools/src/test/java/opennlp/tools/ml/naivebayes/NaiveBayesCorrectnessTest.java b/opennlp-tools/src/test/java/opennlp/tools/ml/naivebayes/NaiveBayesCorrectnessTest.java index 213295c4..a22861ab 100644 --- a/opennlp-tools/src/test/java/opennlp/tools/ml/naivebayes/NaiveBayesCorrectnessTest.java +++ b/opennlp-tools/src/test/java/opennlp/tools/ml/naivebayes/NaiveBayesCorrectnessTest.java @@ -48,7 +48,6 @@ public class NaiveBayesCorrectnessTest { TrainingParameters trainingParameters = new TrainingParameters(); trainingParameters.put(AbstractTrainer.CUTOFF_PARAM, 1); trainingParameters.put(AbstractDataIndexer.SORT_PARAM, false); - ; testDataIndexer = new TwoPassDataIndexer(); testDataIndexer.init(trainingParameters, new HashMap<>()); } diff --git a/opennlp-tools/src/test/java/opennlp/tools/ml/naivebayes/NaiveBayesModelReadWriteTest.java b/opennlp-tools/src/test/java/opennlp/tools/ml/naivebayes/NaiveBayesModelReadWriteTest.java index 11e2a1d9..64de26ab 100644 --- a/opennlp-tools/src/test/java/opennlp/tools/ml/naivebayes/NaiveBayesModelReadWriteTest.java +++ b/opennlp-tools/src/test/java/opennlp/tools/ml/naivebayes/NaiveBayesModelReadWriteTest.java @@ -45,7 +45,6 @@ public class NaiveBayesModelReadWriteTest { TrainingParameters trainingParameters = new TrainingParameters(); trainingParameters.put(AbstractTrainer.CUTOFF_PARAM, 1); trainingParameters.put(AbstractDataIndexer.SORT_PARAM, false); - ; testDataIndexer = new TwoPassDataIndexer(); testDataIndexer.init(trainingParameters, new HashMap<>()); } diff --git a/opennlp-tools/src/test/java/opennlp/tools/ml/naivebayes/NaiveBayesSerializedCorrectnessTest.java b/opennlp-tools/src/test/java/opennlp/tools/ml/naivebayes/NaiveBayesSerializedCorrectnessTest.java index 98d05c07..43915f64 100644 --- a/opennlp-tools/src/test/java/opennlp/tools/ml/naivebayes/NaiveBayesSerializedCorrectnessTest.java +++ b/opennlp-tools/src/test/java/opennlp/tools/ml/naivebayes/NaiveBayesSerializedCorrectnessTest.java @@ -50,7 +50,6 @@ public class NaiveBayesSerializedCorrectnessTest { TrainingParameters trainingParameters = new TrainingParameters(); trainingParameters.put(AbstractTrainer.CUTOFF_PARAM, 1); trainingParameters.put(AbstractDataIndexer.SORT_PARAM, false); - ; testDataIndexer = new TwoPassDataIndexer(); testDataIndexer.init(trainingParameters, new HashMap<>()); }
