This is an automated email from the ASF dual-hosted git repository.

rzo1 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/opennlp.git


The following commit(s) were added to refs/heads/main by this push:
     new f112107c OPENNLP-1548 - Cleanup handling of output streams in cmdline 
tools
f112107c is described below

commit f112107c0a54466cbe79bf02c36d0caa345e6130
Author: Richard Zowalla <[email protected]>
AuthorDate: Sun Nov 3 15:26:20 2024 +0100

    OPENNLP-1548 - Cleanup handling of output streams in cmdline tools
---
 .../java/opennlp/tools/cmdline/doccat/DoccatCrossValidatorTool.java     | 2 +-
 .../src/main/java/opennlp/tools/cmdline/doccat/DoccatEvaluatorTool.java | 2 +-
 .../tools/cmdline/langdetect/LanguageDetectorCrossValidatorTool.java    | 2 +-
 .../opennlp/tools/cmdline/langdetect/LanguageDetectorEvaluatorTool.java | 2 +-
 .../java/opennlp/tools/cmdline/lemmatizer/LemmatizerEvaluatorTool.java  | 2 +-
 .../java/opennlp/tools/cmdline/postag/POSTaggerCrossValidatorTool.java  | 2 +-
 .../main/java/opennlp/tools/cmdline/postag/POSTaggerEvaluatorTool.java  | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

diff --git 
a/opennlp-tools/src/main/java/opennlp/tools/cmdline/doccat/DoccatCrossValidatorTool.java
 
b/opennlp-tools/src/main/java/opennlp/tools/cmdline/doccat/DoccatCrossValidatorTool.java
index af79ec8f..94e6180c 100644
--- 
a/opennlp-tools/src/main/java/opennlp/tools/cmdline/doccat/DoccatCrossValidatorTool.java
+++ 
b/opennlp-tools/src/main/java/opennlp/tools/cmdline/doccat/DoccatCrossValidatorTool.java
@@ -119,7 +119,7 @@ public final class DoccatCrossValidatorTool extends
       reportListener.writeReport();
 
       try {
-        // TODO: is it a problem to close the stream now?
+        reportOutputStream.flush();
         reportOutputStream.close();
       } catch (IOException e) {
         // nothing to do
diff --git 
a/opennlp-tools/src/main/java/opennlp/tools/cmdline/doccat/DoccatEvaluatorTool.java
 
b/opennlp-tools/src/main/java/opennlp/tools/cmdline/doccat/DoccatEvaluatorTool.java
index a6ecd9ee..b2599cce 100644
--- 
a/opennlp-tools/src/main/java/opennlp/tools/cmdline/doccat/DoccatEvaluatorTool.java
+++ 
b/opennlp-tools/src/main/java/opennlp/tools/cmdline/doccat/DoccatEvaluatorTool.java
@@ -136,7 +136,7 @@ public final class DoccatEvaluatorTool extends
       reportListener.writeReport();
 
       try {
-        // TODO: is it a problem to close the stream now?
+        reportOutputStream.flush();
         reportOutputStream.close();
       } catch (IOException e) {
         // nothing to do
diff --git 
a/opennlp-tools/src/main/java/opennlp/tools/cmdline/langdetect/LanguageDetectorCrossValidatorTool.java
 
b/opennlp-tools/src/main/java/opennlp/tools/cmdline/langdetect/LanguageDetectorCrossValidatorTool.java
index 8329a353..b8074c22 100644
--- 
a/opennlp-tools/src/main/java/opennlp/tools/cmdline/langdetect/LanguageDetectorCrossValidatorTool.java
+++ 
b/opennlp-tools/src/main/java/opennlp/tools/cmdline/langdetect/LanguageDetectorCrossValidatorTool.java
@@ -115,7 +115,7 @@ public final class LanguageDetectorCrossValidatorTool 
extends
       reportListener.writeReport();
 
       try {
-        // TODO: is it a problem to close the stream now?
+        reportOutputStream.flush();
         reportOutputStream.close();
       } catch (IOException e) {
         // nothing to do
diff --git 
a/opennlp-tools/src/main/java/opennlp/tools/cmdline/langdetect/LanguageDetectorEvaluatorTool.java
 
b/opennlp-tools/src/main/java/opennlp/tools/cmdline/langdetect/LanguageDetectorEvaluatorTool.java
index bacf0100..d6b358c4 100644
--- 
a/opennlp-tools/src/main/java/opennlp/tools/cmdline/langdetect/LanguageDetectorEvaluatorTool.java
+++ 
b/opennlp-tools/src/main/java/opennlp/tools/cmdline/langdetect/LanguageDetectorEvaluatorTool.java
@@ -136,7 +136,7 @@ public final class LanguageDetectorEvaluatorTool extends
       reportListener.writeReport();
 
       try {
-        // TODO: is it a problem to close the stream now?
+        reportOutputStream.flush();
         reportOutputStream.close();
       } catch (IOException e) {
         // nothing to do
diff --git 
a/opennlp-tools/src/main/java/opennlp/tools/cmdline/lemmatizer/LemmatizerEvaluatorTool.java
 
b/opennlp-tools/src/main/java/opennlp/tools/cmdline/lemmatizer/LemmatizerEvaluatorTool.java
index 1582edfd..73873bc0 100644
--- 
a/opennlp-tools/src/main/java/opennlp/tools/cmdline/lemmatizer/LemmatizerEvaluatorTool.java
+++ 
b/opennlp-tools/src/main/java/opennlp/tools/cmdline/lemmatizer/LemmatizerEvaluatorTool.java
@@ -110,7 +110,7 @@ public final class LemmatizerEvaluatorTool
       reportListener.writeReport();
 
       try {
-        // TODO: is it a problem to close the stream now?
+        reportOutputStream.flush();
         reportOutputStream.close();
       } catch (IOException e) {
         // nothing to do
diff --git 
a/opennlp-tools/src/main/java/opennlp/tools/cmdline/postag/POSTaggerCrossValidatorTool.java
 
b/opennlp-tools/src/main/java/opennlp/tools/cmdline/postag/POSTaggerCrossValidatorTool.java
index baf3358d..613e7475 100644
--- 
a/opennlp-tools/src/main/java/opennlp/tools/cmdline/postag/POSTaggerCrossValidatorTool.java
+++ 
b/opennlp-tools/src/main/java/opennlp/tools/cmdline/postag/POSTaggerCrossValidatorTool.java
@@ -121,7 +121,7 @@ public final class POSTaggerCrossValidatorTool
       reportListener.writeReport();
 
       try {
-        // TODO: is it a problem to close the stream now?
+        reportOutputStream.flush();
         reportOutputStream.close();
       } catch (IOException e) {
         // nothing to do
diff --git 
a/opennlp-tools/src/main/java/opennlp/tools/cmdline/postag/POSTaggerEvaluatorTool.java
 
b/opennlp-tools/src/main/java/opennlp/tools/cmdline/postag/POSTaggerEvaluatorTool.java
index 74c2cfc4..2efbcd26 100644
--- 
a/opennlp-tools/src/main/java/opennlp/tools/cmdline/postag/POSTaggerEvaluatorTool.java
+++ 
b/opennlp-tools/src/main/java/opennlp/tools/cmdline/postag/POSTaggerEvaluatorTool.java
@@ -115,7 +115,7 @@ public final class POSTaggerEvaluatorTool
       reportListener.writeReport();
 
       try {
-        // TODO: is it a problem to close the stream now?
+        reportOutputStream.flush();
         reportOutputStream.close();
       } catch (IOException e) {
         // nothing to do

Reply via email to