krickert commented on code in PR #1138:
URL: https://github.com/apache/opennlp/pull/1138#discussion_r3594143359
##########
opennlp-core/opennlp-runtime/src/main/java/opennlp/tools/util/normalizer/TextNormalizer.java:
##########
@@ -155,18 +171,14 @@ public CharSequenceNormalizer build() {
/**
* {@return an offset-aware composition of the rungs added so far}
*
- * <p>Every rung must be an {@link OffsetAwareNormalizer}. Each
per-code-point fold is one;
- * the folds that delegate to {@link java.text.Normalizer} or to JDK case
mapping (NFC, NFKC,
- * accent folding, confusable folding, and case folding) cannot report
their per-character edits
- * and so are rejected here. The returned normalizer's
+ * <p>Every rung must be an {@link OffsetAwareNormalizer}. NFC, NFKC,
accent folding, confusable
Review Comment:
Done. Switched to “step” in class/Builder javadoc, `@throws`, exception
message, docs, and the matching test assertion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
