The GitHub Actions job "Java CI" on opennlp.git/OPENNLP-1893-hunspell has failed. Run started by GitHub user krickert (triggered by krickert).
Head commit for run: 6f2d9d8204b0e071c31464c6a1cf110b06f6dd53 / Kristian Rickert <[email protected]> OPENNLP-1893: Address review: fold the affix twins, extract tags, complete javadoc - Fold the two per-kind bucketing loops in the HunspellDictionary constructor into a single bucketByBoundary helper that takes the rule list, the kind, and the sink for the rules with empty affix material. - Fold collectSuffixedPartStem and collectPrefixedPartStem, which differed only in the boundary they face, into one collectAffixedPartStem with a suffix marker and an atEdge marker; document what atEdge means at each end. - Extract a parseValue helper for the single-integer directives so COMPOUNDMIN and COMPOUNDWORDMAX no longer share one case body that re-tests which directive it is. - Extract PREFIX_TAG, SUFFIX_TAG, and NO_MATERIAL constants and use them at the affix block header, the rule lines, and the strip and affix material checks. - Give FORBIDDENWORD its own case in the flag directive switch instead of letting the catch-all default assign it, and make that default throw for a directive listed on the outer switch but not handled on the inner one. - Add the missing javadoc on the AffixCondition and HunspellDictionary constructors, the Affix record components, and the splitLines, splitOn, and split helpers. - Convert the single-line accessor javadoc on the compounding and affix bucket getters to the {@return ...} form, and replace the hand-written prose on HunspellStemmerFactory.newStemmer with {@inheritDoc} plus the instancing note. - Trim commentary that restates the code: the bucketing rationale duplicated in HunspellStemmer, the LibreOffice Spanish anecdote on the code point flag reader, and the sentence left dangling in testGermanCompoundsDecompose. - Drop the defensive null and directory guards from the test helpers writeAndLoadFixture and load, which no caller can trip, and document what the real dictionary tests assert. - Fold the repeated ByteArrayInputStream plumbing in HunspellStemmerTest into two load overloads, one UTF-8 and one taking the charset the SET declaration test needs. - Turn the four table-style stemming tests into parameterized tests over their word and expected stem pairs, so a failing row names itself. - Add testNullArgumentsAreRejected, pinning the exact IllegalArgumentException message of every public entry point including the argument names the stream loader reports. - Correct the stemmer manual: name the example files after the fixture the test loads rather than en_US, and state that the printed stems are the fixture's, since which stem a published dictionary yields is that dictionary's decision. Report URL: https://github.com/apache/opennlp/actions/runs/30372433147 With regards, GitHub Actions via GitBox
