This is an automated email from the ASF dual-hosted git repository. arielch pushed a commit to branch AOO418 in repository https://gitbox.apache.org/repos/asf/openoffice.git
commit e2b21863b3b4a632ae31f1c3ca37f10c45da9d88 Author: Ariel Constenla-Haile <[email protected]> AuthorDate: Sun Oct 20 22:15:32 2019 -0300 Avoid ordered comparison between pointer and zero --- main/desktop/source/app/officeipcthread.cxx | 2 +- main/desktop/source/deployment/misc/dp_misc.cxx | 2 +- main/sd/source/ui/view/viewshe3.cxx | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/main/desktop/source/app/officeipcthread.cxx b/main/desktop/source/app/officeipcthread.cxx index 90ad4d9..c92d4f9 100644 --- a/main/desktop/source/app/officeipcthread.cxx +++ b/main/desktop/source/app/officeipcthread.cxx @@ -225,7 +225,7 @@ String CreateMD5FromString( const OUString& aMsg ) // BACK: Str "ababab....0f" Hexcode String rtlDigest handle = rtl_digest_create( rtl_Digest_AlgorithmMD5 ); - if ( handle > 0 ) + if ( handle != NULL) { const sal_uInt8* pData = (const sal_uInt8*)aMsg.getStr(); sal_uInt32 nSize = ( aMsg.getLength() * sizeof( sal_Unicode )); diff --git a/main/desktop/source/deployment/misc/dp_misc.cxx b/main/desktop/source/deployment/misc/dp_misc.cxx index 8e60fad..327df8d 100644 --- a/main/desktop/source/deployment/misc/dp_misc.cxx +++ b/main/desktop/source/deployment/misc/dp_misc.cxx @@ -103,7 +103,7 @@ const OUString OfficePipeId::operator () () } rtlDigest digest = rtl_digest_create( rtl_Digest_AlgorithmMD5 ); - if (digest <= 0) { + if (digest == NULL) { throw RuntimeException( OUSTR("cannot get digest rtl_Digest_AlgorithmMD5!"), 0 ); } diff --git a/main/sd/source/ui/view/viewshe3.cxx b/main/sd/source/ui/view/viewshe3.cxx index c4e2c60..a7a2bbc 100644 --- a/main/sd/source/ui/view/viewshe3.cxx +++ b/main/sd/source/ui/view/viewshe3.cxx @@ -226,7 +226,7 @@ SdPage* ViewShell::CreateOrDuplicatePage ( // When the given page is NULL then use the first page of the document. SdPage* pTemplatePage = pPage; if (pTemplatePage == NULL) - if (pDocument->GetSdPage(0, ePageKind) > 0) + if (pDocument->GetSdPage(0, ePageKind) != NULL) pTemplatePage = pDocument->GetSdPage(0, ePageKind); if (pTemplatePage != NULL && pTemplatePage->TRG_HasMasterPage()) aVisibleLayers = pTemplatePage->TRG_GetMasterPageVisibleLayers();
