This is an automated email from the ASF dual-hosted git repository. msciabarra pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/openserverless-vscode-extension.git
commit a0737f466a48413abb4d258f595c36f50b924ac2 Author: William Grienti <[email protected]> AuthorDate: Mon Mar 18 04:15:55 2024 +0100 tweaks - marketplace icon changed to blue - added error message on failed login - added info message on successful login - removed the single "nuvolaris" terminal. Each command now opens a new one. - changed listener on inputs. It now checks if the form is valid at every keypress. --- media/nuv_market.png | Bin 0 -> 1368 bytes package.json | 2 +- src/extension.ts | 10 +++++++--- src/login/login.ts | 6 +++--- 4 files changed, 11 insertions(+), 7 deletions(-) diff --git a/media/nuv_market.png b/media/nuv_market.png new file mode 100644 index 0000000..4d8a913 Binary files /dev/null and b/media/nuv_market.png differ diff --git a/package.json b/package.json index 9f2f290..7337f5a 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "nuvolaris-vscode-extension", "displayName": "nuvolaris", - "icon": "media/logo.png", + "icon": "media/nuv_market.png", "description": "Nuvolaris extension for VS Code", "version": "1.0.1", "publisher": "nuvolaris", diff --git a/src/extension.ts b/src/extension.ts index 8b84c66..2f76ad2 100644 --- a/src/extension.ts +++ b/src/extension.ts @@ -54,9 +54,10 @@ function handleLogin(username: string, password: string, apiHost: string) { env: {...process.env, NUV_PASSWORD: password} }); loginOutput.appendLine(execLogin.toString()); - + printInfo("You successfully logged in. You can now use the Nuvolaris command palette.") } catch (error: any) { loginOutput.appendLine(error); + printError("An error occurred in the login process. Check the output window for further details.") throw error; } } @@ -64,8 +65,7 @@ function handleLogin(username: string, password: string, apiHost: string) { function launchTerminal(command: string): void { try { - // If a terminal named "Nuvolaris" already exists, launch the command inside that one. - const terminal = vscode.window.terminals.find(t => t.name === NuvolarisTerminalName) || vscode.window.createTerminal(NuvolarisTerminalName); + const terminal = vscode.window.createTerminal(NuvolarisTerminalName); terminal.show(); terminal.sendText(command, true); } catch (error) { @@ -77,3 +77,7 @@ function launchTerminal(command: string): void { function printError(error: any) { return vscode.window.showErrorMessage("Error occurred", error.toString()); } +function printInfo(info: string) { + return vscode.window.showInformationMessage("Info", info); + +} diff --git a/src/login/login.ts b/src/login/login.ts index 748c50f..56c3db3 100644 --- a/src/login/login.ts +++ b/src/login/login.ts @@ -18,13 +18,13 @@ function main() { .addEventListener("click", handleLoginSubmit); LoginPage.getUsername() - .addEventListener("change", validateLogin); + .addEventListener("keypress", validateLogin); LoginPage.getPassword() - .addEventListener("change", validateLogin); + .addEventListener("keypress", validateLogin); LoginPage.getApiHost() - .addEventListener("change", validateLogin); + .addEventListener("keypress", validateLogin); } catch (error: any) { sendError(error);
