rabbah commented on issue #2256: surface errors in runtimes.manifest configuration in the controller logs URL: https://github.com/apache/incubator-openwhisk/pull/2256#issuecomment-302303481 The operation that will throw is the json parse; hence removing the try and documenting that the method will throw is all the same. I slightly prefer the return of a Try so it's explicitly known through the types this method can fail and the caller should address failure; yes you'd have to throw in both controller/invoker main but really it would be achieved by just doing a .get in the result for example hence not much duplication at all. But it's fine to just throw here and document it. You will need to adjust some tests iirc. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
