[incubator-openwhisk-devtools] branch master updated: updated based on rodric's comments (#249)

[mrutkowski]

This is an automated email from the ASF dual-hosted git repository.

mrutkowski pushed a commit to branch master
in repository 
https://gitbox.apache.org/repos/asf/incubator-openwhisk-devtools.git


The following commit(s) were added to refs/heads/master by this push:
     new 76664df  updated based on rodric's comments (#249)
76664df is described below

commit 76664dfe78d1b6fbca274e332d8b6d0fd2f7ef55
Author: Priti Desai <pde...@us.ibm.com>
AuthorDate: Tue Apr 16 14:18:34 2019 -0700

    updated based on rodric's comments (#249)
---
 knative-build/runtimes/javascript/src/service.js | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/knative-build/runtimes/javascript/src/service.js 
b/knative-build/runtimes/javascript/src/service.js
index 726e167..8adfe83 100644
--- a/knative-build/runtimes/javascript/src/service.js
+++ b/knative-build/runtimes/javascript/src/service.js
@@ -20,7 +20,7 @@ var DEBUG = new dbg();
 
 var NodeActionRunner = require('../runner');
 
-function NodeActionService(cfg) {
+function NodeActionService(config) {
 
     var Status = {
         ready: 'ready',
@@ -29,8 +29,6 @@ function NodeActionService(cfg) {
         stopped: 'stopped'
     };
 
-    var config = cfg;
-
     // TODO: save the entire configuration for use by any of the route handlers
     var status = Status.ready;
     var ignoreRunStatus = config.allowConcurrent === undefined ? false : 
config.allowConcurrent.toLowerCase() === "true";
@@ -64,15 +62,6 @@ function NodeActionService(cfg) {
     }
 
     /**
-     * Indicates if we have been initialized which is determined by if we have
-     * created a NodeActionRunner.
-     * @returns {boolean}
-     */
-    this.initialized = function isInitialized(){
-        return (typeof userCodeRunner !== "undefined");
-    };
-
-    /**
      * Starts the server.
      *
      * @param app express app
@@ -122,7 +111,6 @@ function NodeActionService(cfg) {
             } else {
                 setStatus(Status.ready);
                 var msg = "Missing main/no code to execute.";
-                console.error("Internal system error:", msg);
                 DEBUG.functionEndError("[403] " + msg);
                 return Promise.reject(errorMessage(403, msg));
             }