This is an automated email from the ASF dual-hosted git repository.

dgrove pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openwhisk-deploy-kube.git


The following commit(s) were added to refs/heads/master by this push:
     new 742bae9  don't quote username/password before piping to b64enc (#616)
742bae9 is described below

commit 742bae96b3a4f72a5d930a98471111c47c81158a
Author: David Grove <[email protected]>
AuthorDate: Mon Jun 29 11:13:46 2020 -0400

    don't quote username/password before piping to b64enc (#616)
    
    An alternate fix to that proposed in #613 to avoid adding
    quotes around the docker registry username/password.
---
 helm/openwhisk/templates/ow-docker-registry-secret.yaml | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/helm/openwhisk/templates/ow-docker-registry-secret.yaml 
b/helm/openwhisk/templates/ow-docker-registry-secret.yaml
index 7efdab9..e03bddf 100644
--- a/helm/openwhisk/templates/ow-docker-registry-secret.yaml
+++ b/helm/openwhisk/templates/ow-docker-registry-secret.yaml
@@ -15,6 +15,7 @@
 # limitations under the License.
 #
 
+{{- if ne .Values.docker.registry.name "" }}
 apiVersion: v1
 kind: Secret
 metadata:
@@ -23,5 +24,6 @@ metadata:
 {{ include "openwhisk.label_boilerplate" . | indent 4 }}
 type: Opaque
 data:
-  docker_registry_username: {{ .Values.docker.registry.username | quote | 
b64enc }}
-  docker_registry_password: {{ .Values.docker.registry.password | quote | 
b64enc }}
+  docker_registry_username: {{ .Values.docker.registry.username | b64enc }}
+  docker_registry_password: {{ .Values.docker.registry.password | b64enc }}
+{{- end -}}

Reply via email to