This is an automated email from the ASF dual-hosted git repository.
akrabat pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openwhisk-runtime-php.git
The following commit(s) were added to refs/heads/master by this push:
new 106e2cd chore: fix grammar and spelling (#101)
106e2cd is described below
commit 106e2cd5050e8c162af157bda73832072cff08ff
Author: John Bampton <[email protected]>
AuthorDate: Tue Mar 9 18:07:59 2021 +1000
chore: fix grammar and spelling (#101)
---
CONTRIBUTING.md | 4 ++--
README.md | 4 ++--
gradle/README.md | 4 ++--
.../scala/runtime/actionContainers/Php7ActionContainerTests.scala | 2 +-
4 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index d8f8faa..9118557 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -21,7 +21,7 @@
# Contributing to Apache OpenWhisk
-Anyone can contribute to the OpenWhisk project and we welcome your
contributions.
+Anyone can contribute to the OpenWhisk project, and we welcome your
contributions.
There are multiple ways to contribute: report bugs, improve the docs, and
contribute code, but you must follow these prerequisites and guidelines:
@@ -50,7 +50,7 @@ Please raise any bug reports or enhancement requests on the
respective project r
list to see if your issue has already been raised.
A good bug report is one that make it easy for us to understand what you were
trying to do and what went wrong.
-Provide as much context as possible so we can try to recreate the issue.
+Provide as much context as possible, so we can try to recreate the issue.
A good enhancement request comes with an explanation of what you are trying to
do and how that enhancement would help you.
diff --git a/README.md b/README.md
index e3c09a0..49f9301 100644
--- a/README.md
+++ b/README.md
@@ -117,7 +117,7 @@ docker tag whisk/php7.3Action $user_prefix/action-php-v7.3
docker push $user_prefix/action-php-v7.3
```
-Then create the action using your the image from dockerhub
+Then create the action using your image from dockerhub
```
wsk action update myAction myAction.php --docker $user_prefix/action-php-v8.0
```
@@ -146,7 +146,7 @@ Using gradle to run some tests
```
Using IntelliJ:
- Import project as gradle project.
-- Make sure working directory is root of the project/repo
+- Make sure the working directory is root of the project/repo
- Add the following Java VM properties in ScalaTests Run Configuration,
easiest is to change the Defaults for all ScalaTests to use this VM properties
```
-Dhttp.proxyHost=localhost
diff --git a/gradle/README.md b/gradle/README.md
index 14842f1..fc28d4d 100644
--- a/gradle/README.md
+++ b/gradle/README.md
@@ -41,14 +41,14 @@ Project level options that can be used on `distDocker`:
### Test
-To run tests one uses the `test` task. OpenWhisk consolidates tests into a
single `tests` project. Hence the command to run all tests is `gradle
:tests:test`.
+To run tests one uses the `test` task. OpenWhisk consolidates tests into a
single `tests` project. Hence, the command to run all tests is `gradle
:tests:test`.
It is possible to run specific tests using [Gradle
testfilters](https://docs.gradle.org/current/userguide/java_plugin.html#test_filtering).
For example `gradle :tests:test --tests
"your.package.name.TestClass.evenMethodName"`. Wildcard `*` may be used
anywhere.
## Build your own `build.gradle`
In Gradle, most of the tasks we use are default tasks provided by plugins in
Gradle. The [`scala`
Plugin](https://docs.gradle.org/current/userguide/scala_plugin.html) for
example includes tasks, that are needed to build Scala projects. Moreover,
Gradle is aware of *Applications*. The [`application`
Plugin](https://docs.gradle.org/current/userguide/application_plugin.html)
provides tasks that are required to distribute a self-contained application.
When `application` and `scala` are used [...]
-In OpenWhisk, we want to distribute our application via Docker images. Hence
we wrote a "plugin" that creates the task `distDocker`. That task will build an
image from the `Dockerfile` that is located next to the `build.gradle` it is
called from, for example Controller's `Dockerfile` and `build.gradle` are both
located at `core/controller`.
+In OpenWhisk, we want to distribute our application via Docker images. Hence,
we wrote a "plugin" that creates the task `distDocker`. That task will build an
image from the `Dockerfile` that is located next to the `build.gradle` it is
called from, for example Controller's `Dockerfile` and `build.gradle` are both
located at `core/controller`.
If you want to create a new `build.gradle` for your component, simply put the
`Dockerfile` right next to it and include `docker.gradle` by using
diff --git
a/tests/src/test/scala/runtime/actionContainers/Php7ActionContainerTests.scala
b/tests/src/test/scala/runtime/actionContainers/Php7ActionContainerTests.scala
index c884fcf..0c69a1d 100644
---
a/tests/src/test/scala/runtime/actionContainers/Php7ActionContainerTests.scala
+++
b/tests/src/test/scala/runtime/actionContainers/Php7ActionContainerTests.scala
@@ -263,7 +263,7 @@ abstract class Php7ActionContainerTests extends
BasicActionRunnerTests with WskA
})
}
- it should "suport returning a stdClass" in {
+ it should "support returning a stdClass" in {
val (out, err) = withPhp7Container { c =>
val code = """
| <?php
