This is an automated email from the ASF dual-hosted git repository.
omalley pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/orc.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 15c4f8d Push ORC-434 to fix documentation for date/timestamp column
stats.
15c4f8d is described below
commit 15c4f8dce9386840c0655f6dbae736a87ef51064
Author: Owen O'Malley <[email protected]>
AuthorDate: Wed Nov 28 08:22:11 2018 -0800
Push ORC-434 to fix documentation for date/timestamp column stats.
Signed-off-by: Owen O'Malley <[email protected]>
---
specification/ORCv0/index.html | 2 +-
specification/ORCv1/index.html | 10 ++++++++--
specification/ORCv2/index.html | 9 +++++++--
3 files changed, 16 insertions(+), 5 deletions(-)
diff --git a/specification/ORCv0/index.html b/specification/ORCv0/index.html
index 79e3ad1..dca8f46 100644
--- a/specification/ORCv0/index.html
+++ b/specification/ORCv0/index.html
@@ -366,7 +366,7 @@ lengths of the values are recorded.</p>
</code></pre></div></div>
<p>Date columns record the minimum and maximum values as the number of
-days since the epoch (1/1/2015).</p>
+days since the UNIX epoch (1/1/1970 in UTC).</p>
<div class="highlighter-rouge"><div class="highlight"><pre
class="highlight"><code>message DateStatistics {
// min,max values saved as days since epoch
diff --git a/specification/ORCv1/index.html b/specification/ORCv1/index.html
index 66922b8..e6b776a 100644
--- a/specification/ORCv1/index.html
+++ b/specification/ORCv1/index.html
@@ -366,7 +366,7 @@ lengths of the values are recorded.</p>
</code></pre></div></div>
<p>Date columns record the minimum and maximum values as the number of
-days since the epoch (1/1/2015).</p>
+days since the UNIX epoch (1/1/1970 in UTC).</p>
<div class="highlighter-rouge"><div class="highlight"><pre
class="highlight"><code>message DateStatistics {
// min,max values saved as days since epoch
@@ -376,12 +376,18 @@ days since the epoch (1/1/2015).</p>
</code></pre></div></div>
<p>Timestamp columns record the minimum and maximum values as the number of
-milliseconds since the epoch (1/1/2015).</p>
+milliseconds since the UNIX epoch (1/1/1970 00:00:00). Before ORC-135, the
+local timezone offset was included and they were stored as <code
class="highlighter-rouge">minimum</code> and
+<code class="highlighter-rouge">maximum</code>. After ORC-135, the timestamp
is adjusted to UTC before being
+converted to milliseconds and stored in <code
class="highlighter-rouge">minimumUtc</code> and <code
class="highlighter-rouge">maximumUtc</code>.</p>
<div class="highlighter-rouge"><div class="highlight"><pre
class="highlight"><code>message TimestampStatistics {
// min,max values saved as milliseconds since epoch
optional sint64 minimum = 1;
optional sint64 maximum = 2;
+ // min,max values saved as milliseconds since UNIX epoch
+ optional sint64 minimumUtc = 3;
+ optional sint64 maximumUtc = 4;
}
</code></pre></div></div>
diff --git a/specification/ORCv2/index.html b/specification/ORCv2/index.html
index bd4d4a2..fc64ed6 100644
--- a/specification/ORCv2/index.html
+++ b/specification/ORCv2/index.html
@@ -391,7 +391,7 @@ lengths of the values are recorded.</p>
</code></pre></div></div>
<p>Date columns record the minimum and maximum values as the number of
-days since the epoch (1/1/2015).</p>
+days since the UNIX epoch (1/1/1970 in UTC).</p>
<div class="highlighter-rouge"><div class="highlight"><pre
class="highlight"><code>message DateStatistics {
// min,max values saved as days since epoch
@@ -401,12 +401,17 @@ days since the epoch (1/1/2015).</p>
</code></pre></div></div>
<p>Timestamp columns record the minimum and maximum values as the number of
-milliseconds since the epoch (1/1/2015).</p>
+milliseconds since the UNIX epoch (1/1/1970 00:00:00). The timestamp is
+adjusted to UTC before being converted to milliseconds and stored in
+<code class="highlighter-rouge">minimumUtc</code> and <code
class="highlighter-rouge">maximumUtc</code>.</p>
<div class="highlighter-rouge"><div class="highlight"><pre
class="highlight"><code>message TimestampStatistics {
// min,max values saved as milliseconds since epoch
optional sint64 minimum = 1;
optional sint64 maximum = 2;
+ // min,max values saved as milliseconds since UNIX epoch
+ optional sint64 minimumUtc = 3;
+ optional sint64 maximumUtc = 4;
}
</code></pre></div></div>