This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/orc.git
The following commit(s) were added to refs/heads/main by this push:
new c106c8044 ORC-1179: Upgrade checkstyle to 10.2 on Java 11+ (#1130)
c106c8044 is described below
commit c106c80445cac690343e3349f3e0b2abca20bca0
Author: William Hyun <[email protected]>
AuthorDate: Thu May 19 18:31:16 2022 -0700
ORC-1179: Upgrade checkstyle to 10.2 on Java 11+ (#1130)
### What changes were proposed in this pull request?
This PR aims to upgrade checkstyle to 10.2 on Java 11 and above.
However, checkstyle 10+ supports only Java 11+, so I created a Java8
profile to keep Java8 support.
### Why are the changes needed?
- https://checkstyle.org/releasenotes.html#Release_10.2
- https://checkstyle.org/releasenotes.html#Release_10.1
- https://checkstyle.org/releasenotes.html#Release_10.0
- https://checkstyle.org/releasenotes.html#Release_9.3
### How was this patch tested?
Pass the CIs.
Closes #1123
---
java/pom.xml | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/java/pom.xml b/java/pom.xml
index dd7e731f4..f9b656e1a 100644
--- a/java/pom.xml
+++ b/java/pom.xml
@@ -83,6 +83,7 @@
<surefire.version>3.0.0-M5</surefire.version>
<junit.version>5.8.2</junit.version>
<mockito.version>4.5.1</mockito.version>
+ <checkstyle.version>10.2</checkstyle.version>
</properties>
<build>
@@ -280,7 +281,7 @@
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
- <version>9.2.1</version>
+ <version>${checkstyle.version}</version>
</dependency>
</dependencies>
<executions>
@@ -476,6 +477,15 @@
<tools.hadoop.version>3.3.3</tools.hadoop.version>
</properties>
</profile>
+ <profile>
+ <id>java8</id>
+ <activation>
+ <jdk>1.8</jdk>
+ </activation>
+ <properties>
+ <checkstyle.version>9.3</checkstyle.version>
+ </properties>
+ </profile>
</profiles>
<dependencyManagement>
