This is an automated email from the ASF dual-hosted git repository.
yqzhang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/orc.git
The following commit(s) were added to refs/heads/main by this push:
new 541b54398 ORC-1278: Update cmake docs version to 3.12 (#1258)
541b54398 is described below
commit 541b54398d80b0fcdcc9f4c523b52c5eebd96a16
Author: deshanxiao <[email protected]>
AuthorDate: Wed Sep 21 16:25:06 2022 +0800
ORC-1278: Update cmake docs version to 3.12 (#1258)
### What changes were proposed in this pull request?
This PR aims to add a cmake build version in
[README.md](https://github.com/apache/orc/blob/main/README.md)
### Why are the changes needed?
[add_compile_definitions
](https://cmake.org/cmake/help/latest/command/add_compile_definitions.html)only
supprt cmake 3.12+. We can update the docs
[README.md](https://github.com/apache/orc/blob/main/README.md)
In ubuntu 18.04:
> sudo apt install cmake
> make ..
we will get an error:
CMake Error at CMakeLists.txt:147 (add_compile_definitions):
Unknown CMake command "add_compile_definitions".
### How was this patch tested?
---
README.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/README.md b/README.md
index a7d959247..f5216af83 100644
--- a/README.md
+++ b/README.md
@@ -45,7 +45,7 @@ The subdirectories are:
* Install java 1.8 or higher
* Install maven 3.8.6 or higher
-* Install cmake
+* Install cmake 3.12 or higher
To build a release version with debug information:
```shell
