This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/orc.git
The following commit(s) were added to refs/heads/main by this push:
new ff6093c98 ORC-1278: [FOLLOWUP] Update cmake requirement to 3.12
ff6093c98 is described below
commit ff6093c98bf38c06c906dde3207040e1b5b55753
Author: deshanxiao <[email protected]>
AuthorDate: Thu Sep 22 02:30:05 2022 -0700
ORC-1278: [FOLLOWUP] Update cmake requirement to 3.12
### What changes were proposed in this pull request?
This is a followup pr for
[ORC-1278](https://github.com/apache/orc/pull/1258#issue-1378943057)
We adjusted the minimum version requirements for cmake.
### Why are the changes needed?
At present, it is impossible to build using cmake version below 3.12. We
should update it.
### How was this patch tested?
build with cmake 3.12 and pass.
Closes #1259 from deshanxiao/main.
Lead-authored-by: deshanxiao <[email protected]>
Co-authored-by: Yiqun Zhang <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
---
CMakeLists.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 970713c0c..6b15d5f3f 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -10,7 +10,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-cmake_minimum_required (VERSION 2.8.12)
+cmake_minimum_required (VERSION 3.12.0)
if (POLICY CMP0048)
cmake_policy(SET CMP0048 NEW)
endif ()
@@ -96,7 +96,7 @@ if (NOT MSVC)
set(CMAKE_CXX_FLAGS_RELEASE "-O3 -DNDEBUG")
endif ()
message(STATUS "compiler ${CMAKE_CXX_COMPILER_ID} version
${CMAKE_CXX_COMPILER_VERSION}")
-if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
+if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
set (CXX11_FLAGS "-std=c++11")
set (WARN_FLAGS "-Weverything -Wno-c++98-compat -Wno-missing-prototypes")
set (WARN_FLAGS "${WARN_FLAGS} -Wno-c++98-compat-pedantic -Wno-padded")
