This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch branch-1.8
in repository https://gitbox.apache.org/repos/asf/orc.git
The following commit(s) were added to refs/heads/branch-1.8 by this push:
new 7f99a7aa1 ORC-1302: Upgrade Github workflow to use `Visual Studio 16
2019` on Windows
7f99a7aa1 is described below
commit 7f99a7aa10695855a44cfb0b78f21d61a59c20c6
Author: Gang Wu <[email protected]>
AuthorDate: Thu Oct 27 22:38:57 2022 -0700
ORC-1302: Upgrade Github workflow to use `Visual Studio 16 2019` on Windows
### What changes were proposed in this pull request?
Upgrade Github workflow to build on Windows to use higher version of Visual
Studio. To be specific, the workflow uses Visual Studio 16 2019 instead of
Visual Studio 14 2015.
### Why are the changes needed?
This is the prerequisite for the C++17 movement across the C++ code base.
### How was this patch tested?
Pass all the CI checks.
Closes #1297 from wgtmac/ORC-1302.
Authored-by: Gang Wu <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 326664b898b65c01c6189b2c57b3be2a1d6a8732)
Signed-off-by: Dongjoon Hyun <[email protected]>
---
.github/workflows/build_and_test.yml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/.github/workflows/build_and_test.yml
b/.github/workflows/build_and_test.yml
index 57f99a96d..7ebba06d4 100644
--- a/.github/workflows/build_and_test.yml
+++ b/.github/workflows/build_and_test.yml
@@ -80,11 +80,13 @@ jobs:
uses: actions/checkout@v2
- name: Add msbuild to PATH
uses: microsoft/[email protected]
+ with:
+ msbuild-architecture: x64
- name: "Test"
run: |
mkdir build
cd build
- cmake .. -G "Visual Studio 14 2015 Win64" -DCMAKE_BUILD_TYPE=Debug
-DBUILD_LIBHDFSPP=OFF -DBUILD_TOOLS=OFF -DBUILD_JAVA=OFF
+ cmake .. -G "Visual Studio 16 2019" -DCMAKE_BUILD_TYPE=Debug
-DBUILD_LIBHDFSPP=OFF -DBUILD_TOOLS=OFF -DBUILD_JAVA=OFF
cmake --build . --config Debug
ctest -C Debug --output-on-failure
