[orc] branch main updated: ORC-1472: Replace deprecated method in TestMurmur3.java

[william]

This is an automated email from the ASF dual-hosted git repository.

william pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/orc.git


The following commit(s) were added to refs/heads/main by this push:
     new 81ca886b8 ORC-1472: Replace deprecated method in TestMurmur3.java
81ca886b8 is described below

commit 81ca886b835c89d0dfd4f1e7b907d52b62dbc60a
Author: mystic-lama <mysticlama...@gmail.com>
AuthorDate: Tue Aug 8 10:10:52 2023 -0700

    ORC-1472: Replace deprecated method in TestMurmur3.java
    
    ### What changes were proposed in this pull request?
    
    The PR proposes to update the use to deprecate method in TestMurmur3 to 
recommended one
    Hashing.murmur3_32(seed) has been deprecated and documentation recommends 
to use Hashing.murmur3_32_fixed
    
    ### Why are the changes needed?
    
    Google Guava v31+ has the following fix.
    - Issue: https://github.com/google/guava/issues/5648
    - Fix: 
https://github.com/google/guava/commit/a36f08fe312ec16ad86b9206290929f0686d3b02
    
    Updating Deprecated method to use recommended ones is a good practice, as 
deprecated methods might have bugs or gets removed from subsequent releases.
    
    ### How was this patch tested?
    The Unit tests with changes passes
    
    Closes #1573 from mystic-lama/ORC-1472_replace_deprecatemethod_TestMurmur3.
    
    Authored-by: mystic-lama <mysticlama...@gmail.com>
    Signed-off-by: William Hyun <will...@apache.org>
---
 java/core/src/test/org/apache/orc/util/TestMurmur3.java | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/java/core/src/test/org/apache/orc/util/TestMurmur3.java 
b/java/core/src/test/org/apache/orc/util/TestMurmur3.java
index 4dc32926f..75726c7a8 100644
--- a/java/core/src/test/org/apache/orc/util/TestMurmur3.java
+++ b/java/core/src/test/org/apache/orc/util/TestMurmur3.java
@@ -39,7 +39,7 @@ public class TestMurmur3 {
   public void testHashCodesM3_32_string() {
     String key = "test";
     int seed = 123;
-    HashFunction hf = Hashing.murmur3_32(seed);
+    HashFunction hf = Hashing.murmur3_32_fixed(seed);
     int hc1 = hf.hashBytes(key.getBytes(StandardCharsets.UTF_8)).asInt();
     int hc2 = Murmur3.hash32(key.getBytes(StandardCharsets.UTF_8),
         key.getBytes(StandardCharsets.UTF_8).length, seed);
@@ -56,7 +56,7 @@ public class TestMurmur3 {
   public void testHashCodesM3_32_ints() {
     int seed = 123;
     Random rand = new Random(seed);
-    HashFunction hf = Hashing.murmur3_32(seed);
+    HashFunction hf = Hashing.murmur3_32_fixed(seed);
     for (int i = 0; i < 1000; i++) {
       int val = rand.nextInt();
       byte[] data = ByteBuffer.allocate(4).putInt(val).array();
@@ -70,7 +70,7 @@ public class TestMurmur3 {
   public void testHashCodesM3_32_longs() {
     int seed = 123;
     Random rand = new Random(seed);
-    HashFunction hf = Hashing.murmur3_32(seed);
+    HashFunction hf = Hashing.murmur3_32_fixed(seed);
     for (int i = 0; i < 1000; i++) {
       long val = rand.nextLong();
       byte[] data = ByteBuffer.allocate(8).putLong(val).array();
@@ -84,7 +84,7 @@ public class TestMurmur3 {
   public void testHashCodesM3_32_double() {
     int seed = 123;
     Random rand = new Random(seed);
-    HashFunction hf = Hashing.murmur3_32(seed);
+    HashFunction hf = Hashing.murmur3_32_fixed(seed);
     for (int i = 0; i < 1000; i++) {
       double val = rand.nextDouble();
       byte[] data = ByteBuffer.allocate(8).putDouble(val).array();