This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/orc.git


The following commit(s) were added to refs/heads/main by this push:
     new ad7557445 ORC-1479: Enhance examples usage message to use uber jar
ad7557445 is described below

commit ad7557445e30aa3109e54aaf5e22a1a900d5c33e
Author: mystic-lama <[email protected]>
AuthorDate: Fri Aug 18 16:46:17 2023 -0700

    ORC-1479: Enhance examples usage message to use uber jar
    
    ### What changes were proposed in this pull request?
    The PR aims to enhance the message printed when using examples.
    From examples/target directory, if we run the command it gives an error
    
    ```
    bash-5.1$ java -jar orc-examples-*.jar --help
    no main manifest attribute, in orc-examples-2.0.0-SNAPSHOT-sources.jar
    ```
    
    If we replace the usage with following, the error goes away
    
    ```
    $java -jar orc-examples-*-uber.jar [--help]
    ```
    
    ### Why are the changes needed?
    The change shall make it more user friendly, avoiding the error message
    
    ### How was this patch tested?
    Manually tested. Following is the result post
    
    
![example_usage_fix](https://github.com/apache/orc/assets/548559/acd3bc5b-14a1-4dff-93f5-ab80edadfa42)
    
    Closes #1586 from mystic-lama/example_usage_fix.
    
    Authored-by: mystic-lama <[email protected]>
    Signed-off-by: Dongjoon Hyun <[email protected]>
---
 java/examples/src/java/org/apache/orc/examples/Driver.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/java/examples/src/java/org/apache/orc/examples/Driver.java 
b/java/examples/src/java/org/apache/orc/examples/Driver.java
index 69cd2b536..11415e2db 100644
--- a/java/examples/src/java/org/apache/orc/examples/Driver.java
+++ b/java/examples/src/java/org/apache/orc/examples/Driver.java
@@ -67,7 +67,7 @@ public class Driver {
     if (options.command == null) {
       System.err.println("ORC Java Examples");
       System.err.println();
-      System.err.println("usage: java -jar orc-examples-*.jar [--help]" +
+      System.err.println("usage: java -jar orc-examples-*-uber.jar [--help]" +
           " [--define X=Y] <command> <args>");
       System.err.println();
       System.err.println("Commands:");

Reply via email to