This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/orc.git
The following commit(s) were added to refs/heads/branch-2.0 by this push:
new 125f92d77 ORC-1597: [C++] Set bloom filter fpp to 1%
125f92d77 is described below
commit 125f92d77d46123754916b4d0fde1fd6827ef971
Author: sychen <[email protected]>
AuthorDate: Fri Jan 19 11:37:00 2024 -0800
ORC-1597: [C++] Set bloom filter fpp to 1%
### What changes were proposed in this pull request?
Set the bloom filter fpp to 1% in C++ Writer.
### Why are the changes needed?
Java Writer changed `orc.bloom.filter.fpp` to 0.01 in ORC-1338, C++ Writer
is still 0.05.
### How was this patch tested?
GA
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #1764 from cxzl25/ORC-1597.
Authored-by: sychen <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 837a7b593aaa9ad3b2504667065c1871c36d88c1)
Signed-off-by: Dongjoon Hyun <[email protected]>
---
c++/src/Writer.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/c++/src/Writer.cc b/c++/src/Writer.cc
index a98084833..f485e78d9 100644
--- a/c++/src/Writer.cc
+++ b/c++/src/Writer.cc
@@ -58,7 +58,7 @@ namespace orc {
errorStream = &std::cerr;
dictionaryKeySizeThreshold = 0.0;
enableIndex = true;
- bloomFilterFalsePositiveProb = 0.05;
+ bloomFilterFalsePositiveProb = 0.01;
bloomFilterVersion = UTF8;
// Writer timezone uses "GMT" by default to get rid of potential issues
// introduced by moving timestamps between different timezones.
