This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch branch-1.9
in repository https://gitbox.apache.org/repos/asf/orc.git
The following commit(s) were added to refs/heads/branch-1.9 by this push:
new b5c4e0bd7 ORC-1618: Disable building tests for snappy
b5c4e0bd7 is described below
commit b5c4e0bd7ae266903c63ebdb8a22d4dbaf4812d2
Author: David Douard <[email protected]>
AuthorDate: Wed Feb 14 08:40:58 2024 -0800
ORC-1618: Disable building tests for snappy
Disabling the building of tests is a workaround for issue #1791 and is
probably not an issue since snappy tests are not executed as part of the build
process of orc c++ libs.
Note that snappy 1.1.9 and 1.1.10 cannot be used as is because source
assets on snappy's gh page are not buildable out of the box, so stick to 1.1.8
for now.
### What changes were proposed in this pull request?
Disable building snappy tests as a workaround for issue #1791.
### Why are the changes needed?
compilation broken in some situations otherwise (see issue)
### How was this patch tested?
compile & unit tests
### Was this patch authored or co-authored using generative AI tooling?
no
Closes #1792 from douardda/fix-snappy.
Authored-by: David Douard <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 9627a24439099046078c9f300028b79ab27fe33e)
Signed-off-by: Dongjoon Hyun <[email protected]>
---
cmake_modules/ThirdpartyToolchain.cmake | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmake_modules/ThirdpartyToolchain.cmake
b/cmake_modules/ThirdpartyToolchain.cmake
index 47c1a65ba..2d4210bc7 100644
--- a/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cmake_modules/ThirdpartyToolchain.cmake
@@ -87,7 +87,7 @@ else ()
ExternalProject_Add (snappy_ep
URL "https://github.com/google/snappy/archive/${SNAPPY_VERSION}.tar.gz";
- CMAKE_ARGS ${SNAPPY_CMAKE_ARGS}
+ CMAKE_ARGS ${SNAPPY_CMAKE_ARGS} -DSNAPPY_BUILD_TESTS=OFF
${THIRDPARTY_LOG_OPTIONS}
BUILD_BYPRODUCTS "${SNAPPY_STATIC_LIB}")
