(orc) branch main updated: ORC-1685: Use `Pattern Matching for instanceof` in `RecordReaderImpl`

[dongjoon]

This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/orc.git


The following commit(s) were added to refs/heads/main by this push:
     new b5e628f97 ORC-1685: Use `Pattern Matching for instanceof` in 
`RecordReaderImpl`
b5e628f97 is described below

commit b5e628f97ede125bdc3c82050a18282a8403528c
Author: sychen <syc...@ctrip.com>
AuthorDate: Wed Apr 10 10:46:36 2024 -0700

    ORC-1685: Use `Pattern Matching for instanceof` in `RecordReaderImpl`
    
    ### What changes were proposed in this pull request?
    This PR aims to use Java 16 `Pattern Matching for instanceof` (JEP-394) 
syntax in `RecordReaderImpl`.
    
    ### Why are the changes needed?
    Since Apache ORC 2.0 supports Java 17+, we can take advantage of this new 
syntax.
    
    ### How was this patch tested?
    GA
    
    ### Was this patch authored or co-authored using generative AI tooling?
    No
    
    Closes #1884 from cxzl25/ORC-1685.
    
    Authored-by: sychen <syc...@ctrip.com>
    Signed-off-by: Dongjoon Hyun <dongj...@apache.org>
---
 .../java/org/apache/orc/impl/RecordReaderImpl.java | 24 ++++++++--------------
 1 file changed, 8 insertions(+), 16 deletions(-)

diff --git a/java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java 
b/java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java
index c2dbfd469..323f24247 100644
--- a/java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java
+++ b/java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java
@@ -575,43 +575,35 @@ public class RecordReaderImpl implements RecordReader {
                                   boolean useUTCTimestamp) {
     if (index.getNumberOfValues() == 0) {
       return new ValueRange<>(predicate, index.hasNull());
-    } else if (index instanceof IntegerColumnStatistics) {
-      IntegerColumnStatistics stats = (IntegerColumnStatistics) index;
+    } else if (index instanceof IntegerColumnStatistics stats) {
       Long min = stats.getMinimum();
       Long max = stats.getMaximum();
       return new ValueRange<>(predicate, min, max, stats.hasNull());
-    } else if (index instanceof CollectionColumnStatistics) {
-      CollectionColumnStatistics stats = (CollectionColumnStatistics) index;
+    } else if (index instanceof CollectionColumnStatistics stats) {
       Long min = stats.getMinimumChildren();
       Long max = stats.getMaximumChildren();
       return new ValueRange<>(predicate, min, max, stats.hasNull());
-    }else if (index instanceof DoubleColumnStatistics) {
-      DoubleColumnStatistics stats = (DoubleColumnStatistics) index;
+    }else if (index instanceof DoubleColumnStatistics stats) {
       Double min = stats.getMinimum();
       Double max = stats.getMaximum();
       return new ValueRange<>(predicate, min, max, stats.hasNull());
-    } else if (index instanceof StringColumnStatistics) {
-      StringColumnStatistics stats = (StringColumnStatistics) index;
+    } else if (index instanceof StringColumnStatistics stats) {
       return new ValueRange<>(predicate, stats.getLowerBound(),
           stats.getUpperBound(), stats.hasNull(), stats.getMinimum() == null,
           stats.getMaximum() == null);
-    } else if (index instanceof DateColumnStatistics) {
-      DateColumnStatistics stats = (DateColumnStatistics) index;
+    } else if (index instanceof DateColumnStatistics stats) {
       ChronoLocalDate min = stats.getMinimumLocalDate();
       ChronoLocalDate max = stats.getMaximumLocalDate();
       return new ValueRange<>(predicate, min, max, stats.hasNull());
-    } else if (index instanceof DecimalColumnStatistics) {
-      DecimalColumnStatistics stats = (DecimalColumnStatistics) index;
+    } else if (index instanceof DecimalColumnStatistics stats) {
       HiveDecimal min = stats.getMinimum();
       HiveDecimal max = stats.getMaximum();
       return new ValueRange<>(predicate, min, max, stats.hasNull());
-    } else if (index instanceof TimestampColumnStatistics) {
-      TimestampColumnStatistics stats = (TimestampColumnStatistics) index;
+    } else if (index instanceof TimestampColumnStatistics stats) {
       Timestamp min = useUTCTimestamp ? stats.getMinimumUTC() : 
stats.getMinimum();
       Timestamp max = useUTCTimestamp ? stats.getMaximumUTC() : 
stats.getMaximum();
       return new ValueRange<>(predicate, min, max, stats.hasNull());
-    } else if (index instanceof BooleanColumnStatistics) {
-      BooleanColumnStatistics stats = (BooleanColumnStatistics) index;
+    } else if (index instanceof BooleanColumnStatistics stats) {
       Boolean min = stats.getFalseCount() == 0;
       Boolean max = stats.getTrueCount() != 0;
       return new ValueRange<>(predicate, min, max, stats.hasNull());