This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/orc.git
The following commit(s) were added to refs/heads/main by this push:
new 6571e22c2 ORC-1825: [C++] Update Snappy to 1.2.1
6571e22c2 is described below
commit 6571e22c22182736adfa3e18eed46a63d58bae27
Author: William Hyun <[email protected]>
AuthorDate: Sun Jan 5 08:16:21 2025 -0800
ORC-1825: [C++] Update Snappy to 1.2.1
### What changes were proposed in this pull request?
This PR aims to update Snappy to 1.2.1.
### Why are the changes needed?
To use the most recent version of Snappy.
- https://github.com/google/snappy/releases/tag/1.1.8
- https://github.com/google/snappy/releases/tag/1.1.9
- https://github.com/google/snappy/releases/tag/1.1.10
- https://github.com/google/snappy/releases/tag/1.2.0
- https://github.com/google/snappy/releases/tag/1.2.1
### How was this patch tested?
Pass the CIs.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #2101 from williamhyun/snappy.
Authored-by: William Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
---
cmake_modules/ThirdpartyToolchain.cmake | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/cmake_modules/ThirdpartyToolchain.cmake
b/cmake_modules/ThirdpartyToolchain.cmake
index d08a37df6..29ec4d76d 100644
--- a/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cmake_modules/ThirdpartyToolchain.cmake
@@ -21,7 +21,7 @@ set(ORC_INSTALL_INTERFACE_TARGETS)
set(ORC_FORMAT_VERSION "1.0.0")
set(LZ4_VERSION "1.9.3")
-set(SNAPPY_VERSION "1.1.7")
+set(SNAPPY_VERSION "1.2.1")
set(ZLIB_VERSION "1.2.11")
set(GTEST_VERSION "1.12.1")
set(PROTOBUF_VERSION "3.5.1")
@@ -181,7 +181,8 @@ else ()
set(SNAPPY_STATIC_LIB_NAME
"${CMAKE_STATIC_LIBRARY_PREFIX}snappy${CMAKE_STATIC_LIBRARY_SUFFIX}")
set(SNAPPY_STATIC_LIB "${SNAPPY_HOME}/lib/${SNAPPY_STATIC_LIB_NAME}")
set(SNAPPY_CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=${SNAPPY_HOME}
- -DBUILD_SHARED_LIBS=OFF -DCMAKE_INSTALL_LIBDIR=lib)
+ -DBUILD_SHARED_LIBS=OFF -DCMAKE_INSTALL_LIBDIR=lib
+ -DSNAPPY_BUILD_BENCHMARKS=OFF)
if (BUILD_POSITION_INDEPENDENT_LIB)
set(SNAPPY_CMAKE_ARGS ${SNAPPY_CMAKE_ARGS}
-DCMAKE_POSITION_INDEPENDENT_CODE=ON)