This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/orc.git
The following commit(s) were added to refs/heads/main by this push:
new d8e7dbf5e ORC-1835: [C++] Fix cpp-linter-action to build first
d8e7dbf5e is described below
commit d8e7dbf5e77feeefd6105eb5883a3a71b6a1bfc8
Author: Gang Wu <[email protected]>
AuthorDate: Mon Jan 13 09:46:33 2025 -0800
ORC-1835: [C++] Fix cpp-linter-action to build first
### What changes were proposed in this pull request?
Insert a build step before cpp-linter-action to do its job.
### Why are the changes needed?
We need to build C++ code to export command json file.
### How was this patch tested?
Pass CI.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #2113 from wgtmac/fix_cpp_linter.
Authored-by: Gang Wu <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
---
.github/workflows/build_and_test.yml | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/build_and_test.yml
b/.github/workflows/build_and_test.yml
index 7890ffcb3..f1f31cede 100644
--- a/.github/workflows/build_and_test.yml
+++ b/.github/workflows/build_and_test.yml
@@ -179,6 +179,11 @@ jobs:
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
+ - name: Run build
+ run: |
+ mkdir build && cd build
+ cmake .. -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DBUILD_JAVA=OFF
+ cmake --build .
- uses: cpp-linter/[email protected]
id: linter
continue-on-error: true
@@ -191,8 +196,7 @@ jobs:
lines-changed-only: true
thread-comments: true
ignore: 'build|cmake_modules|conan|dev|docker|examples|java|site'
- database: build/compile_commands.json
- extra-args: #-Wno-unused-parameter
+ database: build
- name: Fail fast?!
if: steps.linter.outputs.checks-failed != 0
run: |
