This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/orc.git
The following commit(s) were added to refs/heads/branch-2.0 by this push:
new beecf6eb7 ORC-1837: Remove `commons-csv` from parent `pom.xml`
beecf6eb7 is described below
commit beecf6eb7d08e4bdc351b85b72513ae3d2e5c8d8
Author: Dongjoon Hyun <[email protected]>
AuthorDate: Mon Jan 13 20:08:37 2025 -0800
ORC-1837: Remove `commons-csv` from parent `pom.xml`
### What changes were proposed in this pull request?
This PR aims to remove `commons-csv` from parent `pom.xml`.
### Why are the changes needed?
We can remove `commons-csv` from the parent pom file.
- `commons-cvs` is used in `bench` module only and it's defined in
`pom.xml` of `bench` module already.
- `opencsv` is used in `tools`
```
$ git grep csv | grep import
bench/core/src/java/org/apache/orc/bench/core/convert/GenerateVariants.java:import
org.apache.orc.bench.core.convert.csv.CsvReader;
bench/core/src/java/org/apache/orc/bench/core/convert/csv/CsvReader.java:import
org.apache.commons.csv.CSVFormat;
bench/core/src/java/org/apache/orc/bench/core/convert/csv/CsvReader.java:import
org.apache.commons.csv.CSVParser;
bench/core/src/java/org/apache/orc/bench/core/convert/csv/CsvReader.java:import
org.apache.commons.csv.CSVRecord;
tools/src/java/org/apache/orc/tools/convert/CsvReader.java:import
com.opencsv.CSVParser;
tools/src/java/org/apache/orc/tools/convert/CsvReader.java:import
com.opencsv.CSVParserBuilder;
tools/src/java/org/apache/orc/tools/convert/CsvReader.java:import
com.opencsv.CSVReader;
tools/src/java/org/apache/orc/tools/convert/CsvReader.java:import
com.opencsv.CSVReaderBuilder;
tools/src/java/org/apache/orc/tools/convert/CsvReader.java:import
com.opencsv.exceptions.CsvValidationException;
```
### How was this patch tested?
Pass the CIs.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #2114 from dongjoon-hyun/ORC-1837.
Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 0456efa04212a5a1798087e3938899c77d1c3023)
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit f96d34581b5bd302fc96f7c1f719858a9629d811)
Signed-off-by: Dongjoon Hyun <[email protected]>
---
java/pom.xml | 5 -----
1 file changed, 5 deletions(-)
diff --git a/java/pom.xml b/java/pom.xml
index 6883e4e35..0e9bbf2d9 100644
--- a/java/pom.xml
+++ b/java/pom.xml
@@ -162,11 +162,6 @@
<artifactId>zstd-jni</artifactId>
<version>${zstd-jni.version}</version>
</dependency>
- <dependency>
- <groupId>org.apache.commons</groupId>
- <artifactId>commons-csv</artifactId>
- <version>1.12.0</version>
- </dependency>
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-client-api</artifactId>