[commits] (jeffrey) [11137] - [alpha3 branch] Bug 6230, Remove the expensive selection changed event

[commits]

Title: [commits] (jeffrey) [11137] - [alpha3 branch] Bug 6230, Remove the expensive selection changed event

Revision

11137

Author

jeffrey

Date

2006-07-12 07:34:52 -0700 (Wed, 12 Jul 2006)

Log Message

- [alpha3 branch] Bug 6230, Remove the expensive selection changed event
implemented in r10868 for bug 5140, because in r11039 Mimi disabled
display of selected items in the preview area.

Modified Paths

• branches/0.7alpha3/chandler/parcels/osaf/framework/blocks/BranchPoint.py
• branches/0.7alpha3/chandler/parcels/osaf/framework/blocks/calendar/CalendarBlocks.py

Diff

Modified: branches/0.7alpha3/chandler/parcels/osaf/framework/blocks/BranchPoint.py (11136 => 11137)

--- branches/0.7alpha3/chandler/parcels/osaf/framework/blocks/BranchPoint.py	2006-07-12 13:15:32 UTC (rev 11136)
+++ branches/0.7alpha3/chandler/parcels/osaf/framework/blocks/BranchPoint.py	2006-07-12 14:34:52 UTC (rev 11137)
@@ -98,15 +98,10 @@
         # eventually we might want selectedItem to be an iterable
         # of some kind
         items = event.arguments['items']
-        changeEvent = schema.ns(__parcel__, self.itsView).SelectedItemChanged
         if len(items)==1:
-            if self.selectedItem != items[0]:
-                self.post(changeEvent, {'item' : items[0] })
-                self.selectedItem = items[0]
+            self.selectedItem = items[0]
         else:
-            if self.selectedItem is not None:
-                self.post(changeEvent, {'item' : None })
-                self.selectedItem = None
+            self.selectedItem = None
             
         self.detailItemCollection = \
             self.delegate.getContentsCollection(self.selectedItem,

Modified: branches/0.7alpha3/chandler/parcels/osaf/framework/blocks/calendar/CalendarBlocks.py (11136 => 11137)

--- branches/0.7alpha3/chandler/parcels/osaf/framework/blocks/calendar/CalendarBlocks.py	2006-07-12 13:15:32 UTC (rev 11136)
+++ branches/0.7alpha3/chandler/parcels/osaf/framework/blocks/calendar/CalendarBlocks.py	2006-07-12 14:34:52 UTC (rev 11137)
@@ -401,17 +401,6 @@
     def onSelectAllEventUpdateUI(self, event):
         event.arguments['Enable'] = False
     
-    def onSelectedItemChangedEvent(self, event):
-        """Called directly by the detail view when the item it displays changes.
-        
-        Really this would make sense to be a BroadcastEverywhere block command,
-        but this is slow.
-        """
-        item = event.arguments['item']
-        if item != self.widget.selectedItem:
-            self.widget.selectedItem = item
-            self.synchronizeWidget()
-    
     def instantiateWidget(self):
         if not self.getHasBeenRendered():
             self.setRange( datetime.now().date() )
@@ -436,7 +425,6 @@
                  *arguments, **keywords):
         super(wxPreviewArea, self).__init__(parent, id, *arguments, **keywords)
         self.currentDaysItems = []
-        self.selectedItem = None
         self._avoidDrawing = False
         self.Bind(wx.EVT_PAINT, self.OnPaint)
         self.Bind(wx.EVT_LEFT_DCLICK, self.OnDClick)
@@ -471,24 +459,14 @@
         self.blockItem.post(goto, {'item': item})
 
         self._avoidDrawing = False
-        
-        # after switching to the calendar view the current day often changes
-        if item in self.currentDaysItems:
-            self.selectedItem = item
-            self.Refresh()
 
-        
-
     def OnClick(self, event):
         item = self._getItem(event)
-        if self.selectedItem != item:
-            self.selectedItem = item
-            
-            sidebarBPB = Block.Block.findBlockByName("SidebarBranchPointBlock")
-            sidebarBPB.childrenBlocks.first().postEventByName (
-               'SelectItemsBroadcast', {'items':[item]}
-                )
-            self.Refresh()
+        sidebarBPB = Block.Block.findBlockByName("SidebarBranchPointBlock")
+        sidebarBPB.childrenBlocks.first().postEventByName (
+           'SelectItemsBroadcast', {'items':[item]}
+            )
+        self.Refresh()
 
     def Draw(self, dc):
         """
@@ -573,15 +551,6 @@
                     y += self.lineHeight  #For end calculation
                     break
 
-            if item == self.selectedItem:
-                dc.DestroyClippingRegion()                
-                dc.SetBrush(wx.Brush(selectedBackground, wx.SOLID))
-                dc.DrawRectangle(r.x, y, r.width, self.lineHeight + 2)
-                setClipping()
-                
-                dc.SetTextBackground( selectedBackground )
-                dc.SetTextForeground( selectedColor )
-
             if not (item.allDay or item.anyTime):
                 # Draw the time
                 dc.SetFont(self.timeFont)
@@ -601,10 +570,6 @@
             dc.DrawText(item.displayName, x, y + self.eventFontOffset)
 
             y += self.lineHeight
-
-            if item == self.selectedItem:
-                dc.SetTextBackground( unselectedBackground )
-                dc.SetTextForeground( unselectedColor )
             
         dc.DestroyClippingRegion()
         return y - self.vMargin

_______________________________________________
Commits mailing list
Commits@osafoundation.org
http://lists.osafoundation.org/mailman/listinfo/commits