Gerrrr commented on code in PR #108:
URL: https://github.com/apache/otava/pull/108#discussion_r2596603076
##########
pyproject.toml:
##########
@@ -30,38 +30,45 @@ maintainers = [
]
classifiers = [
"License :: OSI Approved :: Apache Software License",
- "Programming Language :: Python :: 3.8",
- "Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
+ "Programming Language :: Python :: 3.11",
+ "Programming Language :: Python :: 3.12",
+ "Programming Language :: Python :: 3.13",
+ "Programming Language :: Python :: 3.14",
]
dependencies = [
"dateparser>=1.0.0",
- "numpy==1.24.*",
- "python-dateutil>=2.8.1",
- "scipy==1.10.*",
- "ruamel.yaml==0.17.21",
- "requests>=2.25.1",
- "pystache>=0.6.0",
- "tabulate>=0.8.7",
- "validators>=0.18.2",
- "slack-sdk>=3.4.2",
- "google-cloud-bigquery>=3.25.0",
- "pg8000>=1.31.2",
+ "numpy==2.2.0.*",
+ "python-dateutil>=2.9.0",
+ "ruamel.yaml==0.18.16",
+ "requests>=2.32.5",
+ "pystache>=0.6.8",
+ "tabulate>=0.9.0",
+ "validators>=0.35.0",
+ "slack-sdk>=3.39.0",
+ "google-cloud-bigquery>=3.38.0",
+ "pg8000>=1.31.5",
"configargparse>=1.7.1",
"expandvars>=0.12.0",
+
+ # For Python 3.10: last series that supports it
+ "scipy>=1.15,<1.16; python_version < '3.11'",
Review Comment:
I think it is a solid default to support all officially supported Python
versions.
Reasons:
1. It seems reasonable to me for an infrastructure library to be biased
towards being conservative. Stability or lack of maintenance may be as
important of a feature as new shiny features for this kind of software. For
example, all Otava installations I care about at the moment have been running
with 0 maintenance for years, which I am proud of.
2. It does not cost us that much extra effort - Scipy has been the only
library that caused an issue and we only use 1 simple method out of it -
https://github.com/apache/otava/blob/31545205d3f3c0029c06f229c06df525bdeb77b8/otava/analysis.py#L123-L126.
I would not even mind extracting that method and dropping that dependency.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
