StephanDollberg commented on PR #127:
URL: https://github.com/apache/otava/pull/127#issuecomment-3926421689
> Is that what --since-commit does/did? I thought it was essentially a
synonym for --last???
With `--since-commit` it tries to find the stable range around that commit
(range in between the closest changepoint before and after that commit). This
is important because of the fact mentioned above with possible later changes.
`--last` I'd expect to behave differently?
> Can you explain a bit more, how do you provide the data to Otava when you
are dealing with a pull request? (I'm not sure this works the same with all the
databases...)
Sure, so we use the json provider (not sure whether that's the right word).
Then we provide the following data:
- All the data points from master. These get created on merge to master so
we have data for all commits on master
- All the data points for runs from the PR/branch. This will only ever be
one latest data point as we don't run the benchmarks for each individual commit
on a PR. It could be multiple data points though in case users trigger the A/B
comparison multiple times (after pushing changes). For the latter bit is what
we use `--last 1`. As mentioned above we could work around this by only
providing the last dataset to hunter on our side. Just haven't done this for
now as hunter already offered `--last 1` so it was easy to do that way.
> It seems I use the commit time to determine the right position of the pr
commit in the main branch history. I remember spending some time convincing
myself that this is equivalent to looking at merge-base or the chain of parent
refrerenses.
Yeah hunter/otava isn't really git aware so it's all just time based. This
can cause confusion (it did for us initially) but works fine once you get the
timestamps right that you pass to hunter (i.e.: use commit timestamps from the
merge commits or similar).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
