henrikingo commented on PR #154: URL: https://github.com/apache/otava/pull/154#issuecomment-4640835599
> it's worth considering to change the format of flags, instead of using the method name like right now, e.g., --deterministic-edivisive, --orig-edivisive, we should consider two flags: one for statistical test, another for window sliding/skipping tweak. This would even better if we decide to support more statistical tests, avoiding O(n^2) method naming. I thought about this, and we probably should do that, but I consider such granular configurability as "advanced options". For most users I would hope Otava at a given point in time to offer one default and strongly recommended option, and the other --nickname-edivisive options are historical (or in this case, possibly a future) defaults. Ideally also the p-value could be the single tunable anyone ever needs. I increasingly believe the min_threshold has mostly been valuable to workaround bugs, and is less and less needed each time we fix yet another. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
