MrlixiangWE commented on code in PR #166:
URL: https://github.com/apache/otava/pull/166#discussion_r3837955985
##########
otava/config.py:
##########
@@ -128,13 +134,18 @@ class
NestedYAMLConfigFileParser(configargparse.ConfigFileParser):
"""
CLI_CONFIG_SECTIONS = [
+ CsvConfig.NAME,
GraphiteConfig.NAME,
GrafanaConfig.NAME,
SlackConfig.NAME,
PostgresConfig.NAME,
BigQueryConfig.NAME,
]
+ CONFIG_KEY_ALIASES = {
Review Comment:
Done, all three:
1. `CONFIG_KEY_ALIASES` is removed.
2. `quote_char` is the YAML key; `--csv-quote-char` and `CSV_QUOTE_CHAR` are
unchanged. The only `quotechar` left in the tree is the keyword argument of
`csv.reader` itself, which we pass our `quote_char` value to.
3. Rebased onto latest master (47254d9).
198 non-container tests, ruff, isort, flake8 and the package build pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
