pjfanning opened a new issue, #534:
URL: https://github.com/apache/ozhera/issues/534

   
https://github.com/apache/ozhera/blob/66402b2a2b33712fa060efe7aa2f254bb32922cb/trace-etl/trace-etl-server/src/test/java/com/xiaomi/youpin/trace/etl/test/WriterTest.java
   
   * not in an org.apache package
   * has an `@author` tag - this is not the Apache Way - code is owned by all 
contributors, noone should claim credit as the author
   * the test has lots of System.outs - this is not usually regarded as a good 
idea
   * not many asserts - really doesn't seem to test much 
   * lines that have just `;` -- leave them blank (eg line 117)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to