xs3508198 opened a new pull request, #549:
URL: https://github.com/apache/ozhera/pull/549
- Implements a new feature to filter log collection based on log levels.
- Allows users to specify the desired log levels for collection, enhancing
the system's flexibility and user experience.
- The implementation includes a configuration option to specify the desired
log levels and corresponding filtering logic in the log collection module.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!-- Please make sure you have read and understood the contributing
guidelines -->
### Ⅰ. Describe what this PR did
This PR introduces a new feature to filter log collection based on log
levels in our log collection and alerting system. The key highlights include:
User-configurable log levels: Users can now specify the desired log levels
for collection, enhancing the system's flexibility and user experience.
Configuration option: A new configuration option has been added to specify
the desired log levels.
Filtering logic: The log collection module now includes logic to filter logs
based on the specified levels.
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes
#97. -->
No specific issue is addressed by this PR. It is a new feature
implementation.
### Ⅲ. Why don't you add test cases (unit test/integration test)?
Test cases have been added to ensure the functionality works as expected:
Unit tests: Cover the filtering logic in the log collection module.
Integration tests: Verify that the system correctly collects logs based on
the specified log levels.
### Ⅳ. Describe how to verify it
To verify this feature:
Configure the log level filter: Set the desired log levels in the system
configuration.
Generate test logs: Create logs with different levels (e.g., DEBUG, INFO,
WARNING, ERROR).
Check log collection: Ensure that only logs with the specified levels are
collected.
Review configuration logs: Confirm that the filtering settings are applied
correctly.
### Ⅴ. Special notes for reviews
The new configuration option (log_level_filter) should be documented in the
system's user guide.
The filtering logic has been optimized to minimize performance overhead
during log collection.
No backward compatibility issues are expected, but please review the
implementation for any potential edge cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]