This is an automated email from the ASF dual-hosted git repository.
sodonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git
The following commit(s) were added to refs/heads/master by this push:
new 1d8f972 HDDS-5398. Avoid object creation in ReplicationManger debug
log statements (#2379)
1d8f972 is described below
commit 1d8f972ac52a2c6e05cd2312f862ee639893760a
Author: Stephen O'Donnell <[email protected]>
AuthorDate: Wed Jun 30 09:18:26 2021 +0100
HDDS-5398. Avoid object creation in ReplicationManger debug log statements
(#2379)
---
.../apache/hadoop/hdds/scm/container/ReplicationManager.java | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git
a/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ReplicationManager.java
b/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ReplicationManager.java
index 13f19f1..df25206 100644
---
a/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ReplicationManager.java
+++
b/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ReplicationManager.java
@@ -606,7 +606,7 @@ public class ReplicationManager implements MetricsSource,
SCMService {
});
containerManager.updateContainerState(container.containerID(),
HddsProtos.LifeCycleEvent.DELETE);
- LOG.debug("Deleting empty container {} replicas,",
container.containerID());
+ LOG.debug("Deleting empty container replicas for {},", container);
}
/**
@@ -621,8 +621,7 @@ public class ReplicationManager implements MetricsSource,
SCMService {
if (replicas.size() == 0) {
containerManager.updateContainerState(container.containerID(),
HddsProtos.LifeCycleEvent.CLEANUP);
- LOG.debug("Container {} state changes to DELETED",
- container.containerID());
+ LOG.debug("Container {} state changes to DELETED", container);
} else {
// Check whether to resend the delete replica command
final List<DatanodeDetails> deletionInFlight = inflightDeletion
@@ -638,8 +637,7 @@ public class ReplicationManager implements MetricsSource,
SCMService {
filteredReplicas.stream().forEach(rp -> {
sendDeleteCommand(container, rp.getDatanodeDetails(), false);
});
- LOG.debug("Resend delete Container {} command",
- container.containerID());
+ LOG.debug("Resend delete Container command for {}", container);
}
}
}
@@ -692,8 +690,7 @@ public class ReplicationManager implements MetricsSource,
SCMService {
private void handleUnderReplicatedContainer(final ContainerInfo container,
final ContainerReplicaCount replicaSet,
final ContainerPlacementStatus placementStatus) {
- LOG.debug("Handling under-replicated container: {}",
- container.getContainerID());
+ LOG.debug("Handling under-replicated container: {}", container);
Set<ContainerReplica> replicas = replicaSet.getReplica();
try {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
